Internal page links validation for LinkField #8805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g. field.Value = "#someId")
| // e.g.: field.Value = "#divId" | ||
| // Take everything before the first "#" character and check if it's a valid uri. | ||
| // If there is no character before the first "#", consider the value as a valid one (because it is a reference to a div inside the same page) | ||
| var index = field.Value.IndexOf('#'); |
There was a problem hiding this comment.
A technique I like to use for these cases is field.Value.Split('#', 2). It will only give you an array or 1 or 2 values even if there are more #. This way you have access to both parts directly.
There was a problem hiding this comment.
As suggested, refactored the code to use string split function.
sebastienros
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to validate internal page references to a tag id in LinkFields, so I patched the LinkFieldDriver to validate urls like "mysite/mypage#mydiv" or just "#mydiv".
I also changed the hint in the editor shape to add "#someId" to the examples for valid field values.
The field value is divided in prefix and anchor to be sure to properly validate the format of the actual page the field is linking to:
A value like "http://mysite.com/page#div" is divided in two separate validations: