fix(protocol-designer): cleanup and add clear functionality to LiquidToolbox #16843
+279
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… toolbox This PR updates style according to latest designs and implements missing functionality in LiquidToolbox. Here, I add the ability to clear a specific liquid from its loaded wells from its liquid card, and update some other minor style issues. I also add an InfoScreen if there are no loaded liquids on the selected labware and no wells are selected. Closes RQA-3341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates style according to latest designs and implements missing functionality in LiquidToolbox. Here, I add the ability to clear a specific liquid from its loaded wells from its liquid card, and update some other minor style issues. I also add an InfoScreen if there are no loaded liquids on the selected labware and no wells are selected.
Lastly, I add prevention of highlighting labware column and row labels when clicking and dragging
Closes RQA-3341
Test Plan and Hands on Testing
Screen.Recording.2024-11-14.at.5.47.43.PM.mov
Click and drag fix
before fix:
Screen.Recording.2024-11-14.at.5.58.53.PM.mov
after fix:
Screen.Recording.2024-11-14.at.5.56.03.PM.mov
Changelog
InfoScreencomponent and add toLiquidToolboxwhen liquids are empty and no wells are selectedTagcomponent in dropdownReview requests
see test plan
Risk assessmen
low