Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): account for old plate reader serial format when parsing the device info. #16824

Open
wants to merge 1 commit into
base: chore_release-8.2.0
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ async def get_device_information(self) -> Dict[str, str]:
func=partial(self._interface.get_device_information, handle),
)
self._raise_if_error(err.name, f"Error getting device information: {err}")
serial_match = SERIAL_PARSER.fullmatch(device_info.sn)
serial_match = SERIAL_PARSER.match(device_info.sn)
version_match = VERSION_PARSER.match(device_info.version)
serial = serial_match["serial"].strip() if serial_match else "OPTMAA00000"
version = version_match["version"].lower() if version_match else "v0.0.0"
Expand Down
Loading