-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update translation for italian #1058
base: 2.4.x
Are you sure you want to change the base?
Conversation
Hi @luca-vercelli , thank you for the PR! AFAIK translations in Weblate are for master branch (and we have to add it into master first, to prevent future regressions) - probably all the new msgids in the end of the PR are for master branch. Would you mind removing them from this PR? Please do not squash commits, it takes lots of time to review big changes like this, so add your changes as a new commit in your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioned in the comment - please remove the new English strings from the end of PR, since they look like for master branch, and we are good to go.
locale/cups_it.po
Outdated
"Il file ~/.cups/lpoptions fa riferimento a una destinazione predefinita che " | ||
"non esiste." | ||
|
||
#, c-format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new strings from here to the end look like from master branch, please remove them since the PR is for 2.4.x branch.
I removed strings as requested. |
@luca-vercelli I will try to put your commit from 2.4.x into master - it will hopefully take less time than reviewing big MR :D . |
Probably you can just cherry-pick my *first* commit into master. Not the
second one.
Il mar 24 set 2024, 17:32 zdohnal ***@***.***> ha scritto:
… @luca-vercelli <https://github.com/luca-vercelli> I will try to put your
commit from 2.4.x into master - it will hopefully take less time than
reviewing big MR :D .
—
Reply to this email directly, view it on GitHub
<#1058 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACLII2GSSMEOHMQQYMNWUHDZYGAXZAVCNFSM6AAAAABOULZKTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZRGY2DKMJRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Updated translations for
2.4.x
I updated translations on https://hosted.weblate.org/projects/cups/cups/it/, then I downloaded updated .po file. I hope this is the correct workflow.
If I am not wrong, translations on Weblate are from
2.4.x
, not frommaster
.