Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds GitHub hosted runners using the MSVC compiler on Windows.
I tried to build with
-DDYNAMIC_ARCH=ON
. But that failed with:I don't know if that means that there is an issue with DYNAMIC_ARCH in general for that compiler or if that is caused by something else.
I also don't know if
-DTARGET=CORE2
is a good choice in that case. Please, let me know if that should be changed.Since I ended up not building with DYNAMIC_ARCH, I didn't add these rules to
dynamic_arch.yaml
.CMake warned during configure that building shared and static libraries at the same time is unsupported. So, I opted for building both separately in a matrix. (Do you know why that is unsupported?)
I didn't try yet to figure out how to bring a Fortran compiler into this mix. It's building with
-DC_LAPACK=ON
instead.I see a different test is run on Azure for
Windows_cl
(openblas_utest.exe
). Should that be run here, too?