Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 3.2.0 release #234

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Prepare for 3.2.0 release #234

merged 2 commits into from
Jul 9, 2024

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Jul 3, 2024

User description

Describe the change

Update version numbers for pending OpenMS 3.2.0 release

PR checklist


PR Type

Documentation


Description

  • Updated version and release numbers in docs/conf.py for the upcoming 3.2.0 release.
  • Updated version number in CHANGELOG.md to reflect the new release.

Changes walkthrough 📝

Relevant files
Documentation
conf.py
Update version and release numbers in Sphinx configuration

docs/conf.py

  • Updated version from '3.1.0' to '3.2.0'.
  • Updated release from '3.1.0dev' to '3.2.0'.
  • +2/-2     
    CHANGELOG.md
    Update version number in CHANGELOG                                             

    CHANGELOG.md

    • Changed version header from '3.1.0' to '3.2.0'.
    +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @codiumai-pr-agent-pro codiumai-pr-agent-pro bot added the documentation Improvements or additions to documentation label Jul 3, 2024
    Copy link
    Contributor

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    None

    Copy link
    Contributor

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Enhance the detail in changelog entries for better clarity and information

    Consider adding more detailed entries to the changelog to provide better insights into
    what has changed, improved, or been fixed in this version.

    CHANGELOG.md [5]

    -- fix some TOPPAS inaccuracies
    +- Fixed inaccuracies in TOPPAS regarding XYZ feature, enhancing stability and performance.
     
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: Providing more detailed changelog entries improves transparency and helps users understand the changes, improvements, and fixes in the new version.

    9
    Update the release status in the changelog to reflect the current stage more accurately

    Update the release status in the changelog from 'under development' to a more specific
    status such as 'pending release' or 'released', depending on the actual status at the time
    of updating this file.

    CHANGELOG.md [2]

    -----                                OpenMS 3.2.0     (released: under development)    ----
    +----                                OpenMS 3.2.0     (released: pending release)    ----
     
    • Apply this suggestion
    Suggestion importance[1-10]: 6

    Why: Updating the release status to a more specific term like 'pending release' can provide better clarity, but it depends on the actual status at the time of the update.

    6
    Maintainability
    Ensure consistency between version and release variables

    Ensure that the version and release variables are updated together and match to avoid
    inconsistencies in documentation or build processes.

    docs/conf.py [29-34]

    +version = '3.2.0'
    +release = '3.2.0'
     
    -
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Ensuring that the version and release variables are updated together helps maintain consistency in documentation and build processes, which is crucial for maintainability.

    8
    Best practice
    Add a development stage tag to the release version

    Consider using a more descriptive tag for the release version to indicate the development
    stage or stability of the release (e.g., alpha, beta, rc). This can help in distinguishing
    between stable and development versions.

    docs/conf.py [34]

    -release = '3.2.0'
    +release = '3.2.0-beta'
     
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Adding a development stage tag can help distinguish between stable and development versions, which is a good practice. However, it may not be necessary if the release is already stable.

    7

    Copy link
    Contributor

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    CI Failure Feedback 🧐

    Action: build-sphinx

    Failed stage: Run lychee [❌]

    Failure summary:

    The action failed because there were network errors detected in the HTML files:
    *
    build/html/tutorials-and-quickstart-guides/openms-user-tutorial.html had a 403 Forbidden error for
    the URL https://www.knime.org/downloads/overview.
    *
    build/html/getting-started/nextflow-get-started.html had a 404 Not Found error for the URL
    https://nf-co.re/docs/usage/installation.
    * build/html/tutorials/knime-user-tutorial.html had a 403
    Forbidden error for the URL https://www.knime.org/downloads/overview.

    Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    949:  PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.9/x64/lib/pkgconfig
    950:  Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.9/x64
    951:  Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.9/x64
    952:  Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.9/x64
    953:  LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.9/x64/lib
    954:  INPUT_GITHUB_TOKEN: 
    955:  INPUT_ARGS: --cache --max-cache-age 1d './**/*.html' --timeout 40
    956:  INPUT_DEBUG: false
    957:  INPUT_FAIL: true
    ...
    
    963:  | Status        | Count |
    964:  |---------------|-------|
    965:  | 🔍 Total      | 8029  |
    966:  | ✅ Successful | 7732  |
    967:  | ⏳ Timeouts   | 0     |
    968:  | 🔀 Redirected | 0     |
    969:  | 👻 Excluded   | 294   |
    970:  | ❓ Unknown    | 0     |
    971:  | 🚫 Errors     | 3     |
    972:  ## Errors per input
    973:  ### Errors in build/html/tutorials-and-quickstart-guides/openms-user-tutorial.html
    974:  * [403] [https://www.knime.org/downloads/overview](https://www.knime.org/downloads/overview) | Failed: Network error: Forbidden
    975:  ### Errors in build/html/getting-started/nextflow-get-started.html
    976:  * [404] [https://nf-co.re/docs/usage/installation](https://nf-co.re/docs/usage/installation) | Failed: Network error: Not Found
    977:  ### Errors in build/html/tutorials/knime-user-tutorial.html
    978:  * [403] [https://www.knime.org/downloads/overview](https://www.knime.org/downloads/overview) | Failed: Network error: Forbidden
    979:  ##[error]Process completed with exit code 2.
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    @timosachsenberg
    Copy link
    Contributor

    can you give the lychee error messages a quick check if they are real? otherwise good to merge

    Copy link
    Contributor

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    CI Failure Feedback 🧐

    Action: build-sphinx

    Failed stage: Run lychee [❌]

    Failure summary:

    The action failed because there were 2 errors detected in the HTML files:
    * The URL
    https://www.knime.org/downloads/overview returned a 403 Forbidden error in the file
    build/html/tutorials-and-quickstart-guides/openms-user-tutorial.html.
    * The same URL
    https://www.knime.org/downloads/overview also returned a 403 Forbidden error in the file
    build/html/tutorials/knime-user-tutorial.html.

    Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    947:  PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.9/x64/lib/pkgconfig
    948:  Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.9/x64
    949:  Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.9/x64
    950:  Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.9/x64
    951:  LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.9/x64/lib
    952:  INPUT_GITHUB_TOKEN: 
    953:  INPUT_ARGS: --cache --max-cache-age 1d './**/*.html' --timeout 40
    954:  INPUT_DEBUG: false
    955:  INPUT_FAIL: true
    ...
    
    961:  | Status        | Count |
    962:  |---------------|-------|
    963:  | 🔍 Total      | 8029  |
    964:  | ✅ Successful | 7733  |
    965:  | ⏳ Timeouts   | 0     |
    966:  | 🔀 Redirected | 0     |
    967:  | 👻 Excluded   | 294   |
    968:  | ❓ Unknown    | 0     |
    969:  | 🚫 Errors     | 2     |
    970:  ## Errors per input
    971:  ### Errors in build/html/tutorials-and-quickstart-guides/openms-user-tutorial.html
    972:  * [403] [https://www.knime.org/downloads/overview](https://www.knime.org/downloads/overview) | Failed: Network error: Forbidden
    973:  ### Errors in build/html/tutorials/knime-user-tutorial.html
    974:  * [403] [https://www.knime.org/downloads/overview](https://www.knime.org/downloads/overview) | Failed: Network error: Forbidden
    975:  ##[error]Process completed with exit code 2.
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    @mr-c
    Copy link
    Contributor Author

    mr-c commented Jul 9, 2024

    https://www.knime.com/downloads/overview is now a 403

    Prior to this, and at least since October, 2017, it was a 301 redirect to https://www.knime.com/downloads/

    https://web.archive.org/web/20171004005730/https://www.knime.com/downloads/overview

    @mr-c mr-c merged commit dac4b18 into develop Jul 9, 2024
    1 check passed
    @mr-c mr-c deleted the prepare_3.2.0 branch July 9, 2024 08:34
    @timosachsenberg
    Copy link
    Contributor

    thanks for fixing the URL

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    documentation Improvements or additions to documentation Review effort [1-5]: 1
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants