-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement task restart policies #280
base: main
Are you sure you want to change the base?
Commits on Jul 16, 2024
-
Added placeholder tests for proposed methods
* Test: test_add_task_restart_policy_patterns * Test: test_get_task_restart_policy_patterns * Test: test_remove_task_restart_policy_patterns * Test: test_clear_task_restart_policy_patterns * Test: test_task_resolve_restarts
Configuration menu - View commit details
-
Copy full SHA for 7f752b3 - Browse repository at this point
Copy the full SHA 7f752b3View commit details -
Added models for new node types
* TaskRestartPattern * TaskRestartPolicy * TaskHistory
Configuration menu - View commit details
-
Copy full SHA for dd8f0e9 - Browse repository at this point
Copy the full SHA dd8f0e9View commit details
Commits on Jul 17, 2024
-
Updated new GufeTokenizable models in statestore
* Removed TaskRestartPolicy and TaskHistory * Added Traceback
Configuration menu - View commit details
-
Copy full SHA for da17e45 - Browse repository at this point
Copy the full SHA da17e45View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7f63d4 - Browse repository at this point
Copy the full SHA b7f63d4View commit details
Commits on Jul 18, 2024
-
Added validation and unit tests for storage models
* TaskReturnPattern: Confirm that the input pattern is a string type and that it is not empty. * Traceback: Confirm that the input is a list of strings and that none of them are empty.
Configuration menu - View commit details
-
Copy full SHA for 6a167f1 - Browse repository at this point
Copy the full SHA 6a167f1View commit details
Commits on Jul 22, 2024
-
Added
taskhub_sk
toTaskRestartPattern
Similar to `TaskHub`s, the `TaskRestartPattern` needs additonal hashed data to uniquely identify it as a Neo4j node (via the gufe key). The unit tests have been updated to reflect this change.
Configuration menu - View commit details
-
Copy full SHA for a10e235 - Browse repository at this point
Copy the full SHA a10e235View commit details -
Added
statestore
methods for restart patterns`statestore` methods have been added to modify the database state: * add_task_restart_patterns * remove_task_restart_patterns * get_task_restart_patterns Tests were added for each method in the integration tests for the statestore.
Configuration menu - View commit details
-
Copy full SHA for b99d8ef - Browse repository at this point
Copy the full SHA b99d8efView commit details
Commits on Jul 25, 2024
-
Added APPLIES relationship when adding pattern
The `add_task_restart_patterns` method now establishes the APPLIES relationship between the each new pattern and all Tasks ACTIONED on the corresponding TaskHub. Added testing for creation of the APPLIES relationship, asserting the number of created connections over multiple TaskHubs and Tasks. Further subdivided the test classes. Additionally added a `set_task_restart_patterns_max_retries` method for updating the max_retries of a TaskRestartPattern.
Configuration menu - View commit details
-
Copy full SHA for 39f9868 - Browse repository at this point
Copy the full SHA 39f9868View commit details
Commits on Jul 26, 2024
-
Establish APPLIES when actioning a Task
"actioning" a Task on a TaskHub with preexisting TaskRestartPatterns created the APPLIES relationship between them with a num_retries value of 0. This behavior is tested in the test_action_task function in the statestore.
Configuration menu - View commit details
-
Copy full SHA for 988155f - Browse repository at this point
Copy the full SHA 988155fView commit details -
Canceling a Task removes the APPLIES relationship
When an actioned Task is canceled and also has an APPLIES relationship with a TaskRestartPattern, APPLIES is removed between the two nodes. Removed org, project, and campaign fields since they are not necessary for the APPLIES relationship.
Configuration menu - View commit details
-
Copy full SHA for d3f25f8 - Browse repository at this point
Copy the full SHA d3f25f8View commit details
Commits on Aug 1, 2024
-
Task status changes affect APPLIES relationship
Setting an actioned Task status to the following statuses now removes the APPLIES relationship from attached TaskRestartPatterns: * complete * invalid * deleted NOTE: tests have not been added for this yet
Configuration menu - View commit details
-
Copy full SHA for 510ae66 - Browse repository at this point
Copy the full SHA 510ae66View commit details
Commits on Aug 4, 2024
-
Tests for Task status change on APPLIES
Confirming that changing the status of an actioned Task to any of the following removes the APPLIES relationship: * complete * invalid * deleted
Configuration menu - View commit details
-
Copy full SHA for 2310fd5 - Browse repository at this point
Copy the full SHA 2310fd5View commit details -
Added method (unimplemented) calls for restarts
New statestore method placeholders: - add_task_traceback - resolve_task_restarts The compute api will add a Task Traceback and resolve restarts for returned failed Tasks. When a list of restart patterns are added, restarts are resolved.
Configuration menu - View commit details
-
Copy full SHA for ea2851f - Browse repository at this point
Copy the full SHA ea2851fView commit details
Commits on Aug 5, 2024
-
Implemented add_protocol_dag_result_ref_traceback
* Renamed add_task_traceback to add_protocol_dag_result_ref_traceback * Added tests for add_protocol_dag_result_ref_traceback
Configuration menu - View commit details
-
Copy full SHA for 8e011be - Browse repository at this point
Copy the full SHA 8e011beView commit details
Commits on Aug 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4f07dde - Browse repository at this point
Copy the full SHA 4f07ddeView commit details
Commits on Aug 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 78c4551 - Browse repository at this point
Copy the full SHA 78c4551View commit details
Commits on Aug 13, 2024
-
Built out custom fixture for testing restart policies
Implemented half of the resolve_task_restarts test
Configuration menu - View commit details
-
Copy full SHA for 7acc003 - Browse repository at this point
Copy the full SHA 7acc003View commit details
Commits on Aug 19, 2024
-
Added the
chainable
decorator to Neo4jStoreWith this decorator, if a transaction isn't passed as a keyword arg, one is automatically created (and closed). This allows a chaining behavior where many method calls share a single transaction object.
Configuration menu - View commit details
-
Copy full SHA for 03d9fa1 - Browse repository at this point
Copy the full SHA 03d9fa1View commit details -
Configuration menu - View commit details
-
Copy full SHA for aad97e3 - Browse repository at this point
Copy the full SHA aad97e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a655dc7 - Browse repository at this point
Copy the full SHA a655dc7View commit details
Commits on Aug 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5bb6700 - Browse repository at this point
Copy the full SHA 5bb6700View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe4b87b - Browse repository at this point
Copy the full SHA fe4b87bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a6f980 - Browse repository at this point
Copy the full SHA 8a6f980View commit details
Commits on Sep 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 93eb5f5 - Browse repository at this point
Copy the full SHA 93eb5f5View commit details
Commits on Sep 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0900f39 - Browse repository at this point
Copy the full SHA 0900f39View commit details -
* Removed custom tokenization * Implemented _defaults to allow default tokenization to work
Configuration menu - View commit details
-
Copy full SHA for c8ddafc - Browse repository at this point
Copy the full SHA c8ddafcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a59499 - Browse repository at this point
Copy the full SHA 2a59499View commit details -
Updated cancel and increment logic
cancel_map has been changed from a defaultdict to a base dict and instead using the dict.get method to return None. Additionally added a set of all task/taskhub pairs that is later used to determine what should be canceled. I've also added grouping on taskhubs so the number of calls to cancel_tasks is minimized.
Configuration menu - View commit details
-
Copy full SHA for 148d048 - Browse repository at this point
Copy the full SHA 148d048View commit details -
Configuration menu - View commit details
-
Copy full SHA for 645b2e4 - Browse repository at this point
Copy the full SHA 645b2e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a8eeca - Browse repository at this point
Copy the full SHA 3a8eecaView commit details -
Clarified comment and added complimentary assertion
Also expanded test to check behavior of the task that was meant to be waiting.
Configuration menu - View commit details
-
Copy full SHA for ea6e66f - Browse repository at this point
Copy the full SHA ea6e66fView commit details
Commits on Sep 13, 2024
-
We don't want to change `_defaults()` from what's done in the base class unless we have real default values to leave out of the hash.
Configuration menu - View commit details
-
Copy full SHA for 7a4b114 - Browse repository at this point
Copy the full SHA 7a4b114View commit details
Commits on Sep 19, 2024
-
Merge pull request #286 from OpenFreeEnergy/feature/iss-277-restart-p…
…olicy_resolve_restarts Restart policy: resolve restarts
Configuration menu - View commit details
-
Copy full SHA for cf0e961 - Browse repository at this point
Copy the full SHA cf0e961View commit details
Commits on Sep 24, 2024
-
The addition of source_keys and failure_keys was not included in the unit tests so all initializations of Tracebacks failed. I've added default values for the test class.
Configuration menu - View commit details
-
Copy full SHA for 6066796 - Browse repository at this point
Copy the full SHA 6066796View commit details
Commits on Sep 25, 2024
-
Added API endpoints for managing restart policies
* add_task_restart_patterns * remove_task_restart_patterns * get_task_restart_patterns * set_task_restart_patterns_max_retries Additionally, I added the get_taskhubs method to Neo4jStore since get_taskhub will only get the taskhub for a single network at a time. It might make sense to replace the old method with this new one.
Configuration menu - View commit details
-
Copy full SHA for fcf77a0 - Browse repository at this point
Copy the full SHA fcf77a0View commit details
Commits on Oct 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cea16bc - Browse repository at this point
Copy the full SHA cea16bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4da776 - Browse repository at this point
Copy the full SHA a4da776View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fdc25a7 - Browse repository at this point
Copy the full SHA fdc25a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51194ff - Browse repository at this point
Copy the full SHA 51194ffView commit details
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f03417c - Browse repository at this point
Copy the full SHA f03417cView commit details
Commits on Oct 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 977c896 - Browse repository at this point
Copy the full SHA 977c896View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d2d8f6 - Browse repository at this point
Copy the full SHA 2d2d8f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7dcd5c - Browse repository at this point
Copy the full SHA d7dcd5cView commit details
Commits on Oct 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 006e689 - Browse repository at this point
Copy the full SHA 006e689View commit details