Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to new version of sphinx #169

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

mikemhenry
Copy link
Collaborator

No description provided.

@mikemhenry
Copy link
Collaborator Author

I am not sure if this fixes the issue (the menu doesn't load on the PR, but I am not sure if it normally does), but it won't hurt

Source:
sphinx-doc/sphinx#11586 (comment)

@mikemhenry
Copy link
Collaborator Author

Hmmm testing on another repo it should, so don't merge this in yet

@mikemhenry
Copy link
Collaborator Author

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9a20f20) 82.73% compared to head (3117c9a) 82.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   82.73%   82.28%   -0.45%     
==========================================
  Files          21       21              
  Lines        2722     2721       -1     
==========================================
- Hits         2252     2239      -13     
- Misses        470      482      +12     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry
Copy link
Collaborator Author

@dotsdl

Okay that worked! This is ready to merge! I may fix it a different way later (depending on the answer I get here: readthedocs/sphinx_rtd_theme#1452 (comment)) but for now this will work.

@dotsdl
Copy link
Member

dotsdl commented Sep 27, 2023

Think we're now held back by myst-nb: executablebooks/MyST-NB#493

Doesn't allow us to use sphinx >= 4.0`. 😢

@mikemhenry
Copy link
Collaborator Author

Bummer and it looks like it might take a while to get that updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants