-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump to new version of sphinx #169
base: main
Are you sure you want to change the base?
Conversation
I am not sure if this fixes the issue (the menu doesn't load on the PR, but I am not sure if it normally does), but it won't hurt |
Hmmm testing on another repo it should, so don't merge this in yet |
Will try this: readthedocs/sphinx_rtd_theme#1452 (comment) but also this readthedocs/sphinx_rtd_theme#1452 (comment) |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 82.73% 82.28% -0.45%
==========================================
Files 21 21
Lines 2722 2721 -1
==========================================
- Hits 2252 2239 -13
- Misses 470 482 +12 ☔ View full report in Codecov by Sentry. |
Okay that worked! This is ready to merge! I may fix it a different way later (depending on the answer I get here: readthedocs/sphinx_rtd_theme#1452 (comment)) but for now this will work. |
Think we're now held back by Doesn't allow us to use |
Bummer and it looks like it might take a while to get that updated. |
No description provided.