Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow autostart to be configured by conf.json Issue #301 #332

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

louisza
Copy link

@louisza louisza commented Sep 15, 2022

Issue #301 autostart

@louisza louisza closed this Sep 15, 2022
@louisza
Copy link
Author

louisza commented Sep 15, 2022

Rest failing, likely due to dependencies will revert and do new pull request

@knoxfighter
Copy link
Member

knoxfighter commented Sep 15, 2022

no, that fail is not your mistake, it has nothing to do with this PR :)
The develop branch is broken as well.

That error is fixed in #326

@knoxfighter knoxfighter reopened this Sep 15, 2022
…cript-dependencies

324 update javascript dependencies
@Diman0 Diman0 mentioned this pull request Oct 22, 2024
@Mattie112
Copy link
Contributor

I can have a look this weekend to see if this is still a valid fix.

Couple of related issues:
#409
#301
#362

@knoxfighter knoxfighter changed the base branch from develop to master October 22, 2024 14:43
@knoxfighter knoxfighter changed the base branch from master to develop October 22, 2024 14:43
@Mattie112
Copy link
Contributor

Mattie112 commented Oct 26, 2024

@knoxfighter tested this and it works. However it is now type 'string' so you will have to put it as a string in your conf.json

Changing it to type bool will also require to change the type of the ENV var OR something like:

	config.Autostart = flags.Autostart == "true"

In the mapFlags method.

Also for reference: Adding FSM_AUTOSTART=true to your environment worked fine without any changes for me.
EDIT: ^ only works on develop not on master

EDIT2: And just to be sure, this PR does also not work on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants