Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/dart-dio/multipart-file-handling #20106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vasilich6107
Copy link
Contributor

@vasilich6107 vasilich6107 commented Nov 14, 2024

in case if we have

      responses:
        '200':
          description: File downloaded successfully
          content:
            application/octet-stream:
              schema:
                type: string
                format: binary

The code fails with Exception

 final rawData = _response.data;
      _responseData = rawData == null
          ? null
          : deserialize<MultipartFile, MultipartFile>(rawData, 'MultipartFile',
              growable: true);

cause deserialize does not have a case for MultipartFile

This PR added handling the case 'MultipartFile':

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@vasilich6107
Copy link
Contributor Author

@jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)

@vasilich6107 vasilich6107 force-pushed the bugfix/dart-dio/multipart-file-handling branch from f7af624 to 641c1e3 Compare November 14, 2024 20:56
@ahmednfwela
Copy link
Contributor

Question is, should a MultipartFile be returned when response type is application/octet-stream ?
I think it's better to change the return type entirely to Uint8List but I am not sure how

@vasilich6107
Copy link
Contributor Author

Hey @ahmednfwela
For now it is just a bugfix with deserializtion

@ahmednfwela
Copy link
Contributor

well, this fix will still not fix the bug, since rawData will never be a MultipartFile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants