Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GO] Returns the correct data type from New**FromValue func for enums #20085

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simodima
Copy link

@simodima simodima commented Nov 12, 2024

Fixes #20084
Returns the correct data type

Returning the correct data type from the GO server function New{{{classname}}}FromValue
The current implementation has a bug since it always returns an empty string when the ev is not valid.

Previous bugged code

func NewErrorCodesFromValue(v int32) (ErrorCodes, error) {
	ev := ErrorCodes(v)
	if ev.IsValid() {
		return ev, nil
	}

	return "", fmt.Errorf("invalid value '%v' for ErrorCodes: valid values are %v", v, AllowedErrorCodesEnumValues)
}

The fixed code

func NewErrorCodesFromValue(v int32) (ErrorCodes, error) {
	ev := ErrorCodes(v)
	if ev.IsValid() {
		return ev, nil
	}
	noValue := new(ErrorCodes)
	return *noValue, fmt.Errorf("invalid value '%v' for ErrorCodes: valid values are %v", v, AllowedErrorCodesEnumValues)
}

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Returns the correct data type
@simodima simodima changed the title [GO]Returning the correct data type from the GO server function New{{{classname}}}FromValue Update model.mustache [GO] Returns the correct data type from New**FromValue func for enums Nov 12, 2024
@simodima
Copy link
Author

Mentioning @antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5 as per the

@mention the technical committee members

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][GO-SERVER] Enum fromValue functions always returns string in case of invalid values
1 participant