Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #507: clarify that "canonical" job result link should include query parameters #513

Open
wants to merge 1 commit into
base: draft
Choose a base branch
from

Conversation

soxofaan
Copy link
Member

Issue #507: clarify that "canonical" job result link should include query parameters

@m-mohr
Copy link
Member

m-mohr commented Sep 30, 2023

Thinking a bit more about this, I think this was intentionally left out as implementations could either choose to include this parameter in the canonical link href or encode it implicitly in the signed URL. Depending on the implementation, it should or should not be part of the canonical href. Clients (which includes the aggregator) would basically just follow the link that was provided. If the href doesn't work as provided by the implementation, that's an implementation bug.

Makes sense, right? If yes, could you update the PR to clarify this?

@soxofaan
Copy link
Member Author

soxofaan commented Oct 9, 2023

implementations could either choose to include this parameter in the canonical link href or encode it implicitly in the signed URL.

That's what I actually meant here: query parameters should be preserved in the canonical URL: visibly in the URL with a trailing ?partial=true, or embedded in the opaque blob of the signed URL. How it's done doesn't matter, as long as the original parameter is preserved.
But that's apparently not clear from the current PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clarification: canonical (signed) batch job result URL + partial query param?
2 participants