[cpackget] add command shall download the pack and extract the license files to .Download #196 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e files to .Download #196 cpackget is already prepared to just extract the EULA and then quit, and to auto-accept EULA in a next step. Changed the program flow to skip showing the license / preparing the license UI if already the command line specifies the extract option. If the license file already exists it will be deleted (error if not possible). Added for encoded progress: * L: License file follows I: [L:F"C:\Users\user\AppData\Local\Arm\Packs\.Download\Keil.MDK-Middleware_Graphics.1.3.0.pack.license.rtf"]
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
- Coverage 78.96% 77.67% -1.29%
==========================================
Files 22 22
Lines 2586 2625 +39
==========================================
- Hits 2042 2039 -3
- Misses 403 435 +32
- Partials 141 151 +10
☔ View full report in Codecov by Sentry. |
soumeh01
reviewed
Aug 10, 2023
soumeh01
previously approved these changes
Aug 10, 2023
"test installing pack with license extracted but prev license exist"
|
changes have been integrated during #197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpackget is already prepared to just extract the EULA and then quit, and to auto-accept EULA in a next step. Changed the program flow to skip showing the license / preparing the license UI if already the command line specifies the extract option.
If the license file already exists it will be deleted (error if not possible).
Added for encoded progress:
see #196