Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding secure-only SW model #323

Merged
merged 6 commits into from
Sep 2, 2024
Merged

adding secure-only SW model #323

merged 6 commits into from
Sep 2, 2024

Conversation

jkrech
Copy link
Member

@jkrech jkrech commented Aug 27, 2024

No description provided.

@jkrech jkrech self-assigned this Aug 27, 2024
@jkrech jkrech linked an issue Aug 27, 2024 that may be closed by this pull request
@ReinhardKeil
Copy link
Collaborator

I suggest to hold back with this modification. Devices that have TrustZone can all execute a secure-only project. IMHO this is only relevant for the CMSIS-Toolbox, but not for the PDSC specification.

@jkrech
Copy link
Member Author

jkrech commented Aug 27, 2024

Dsecure is only used in conditions and allows to select different components / files within a component based on the selection of the software model of the project.
It does not describe a capability/feature of a processor/device.

schema/PACK.xsd Outdated Show resolved Hide resolved
corrected comment
@jkrech jkrech marked this pull request as draft August 28, 2024 14:51
@jkrech
Copy link
Member Author

jkrech commented Aug 28, 2024

This PR is parked until we have evidence that component/file filtering based on Dsecure="Secure-only" is required or whether using component variants specified in dedicated template projects solves this sufficiently.

@VGRSTM
Copy link

VGRSTM commented Aug 29, 2024

This PR is parked until we have evidence that component/file filtering based on Dsecure="Secure-only" is required or whether using component variants specified in dedicated template projects solves this sufficiently.

I guess at least it may have an impact on linker files ... I consider this like enough to unpark.

@jkrech jkrech marked this pull request as ready for review September 2, 2024 07:31
@jkrech jkrech requested review from brondani and jeromecoutant and removed request for jeromecoutant September 2, 2024 07:32
Copy link

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has impact in all etc/XXX.cmake files

Copy link
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech merged commit 26e13e0 into main Sep 2, 2024
3 checks passed
@jkrech jkrech deleted the secure-only branch September 2, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enrich Dsecure condition with FullSecure test
5 participants