Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake reference to CAN Stack #28

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Conversation

ad3154
Copy link
Member

@ad3154 ad3154 commented Oct 13, 2024

Now that the VT server PR is merged on the main stack, this change starts explicitly setting the commit of the stack to use when building the VT.

This will:

  • Reduce the number of times fetch content has to check the upstream repo
  • Prevent rebase issues that can happen when tracking a branch, reducing the need to clean and rebuild the CMake cache
  • Provide tighter control over our largest dependency (the stack)

@ad3154 ad3154 self-assigned this Oct 13, 2024
@ad3154 ad3154 merged commit c10bd18 into main Oct 13, 2024
4 checks passed
@ad3154 ad3154 deleted the adrian/can-stack-use-commit-sha branch October 13, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant