-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit multiple services #42
Conversation
…in record which is not ready yet
|
||
return ( | ||
<Form style={{ margin: 20 }}> | ||
<Field {...getFieldContent('name', data)} component={Input} name="name" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can do a funtion renderField(fieldname)
and in Form do somenthing like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather keep it like this because the same way it is done in publish flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
] | ||
|
||
return ( | ||
<Form style={{ margin: 20 }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also here like in formAddService
you can do a
cont renderField = (filed) => {
<Field.../>
}
Fixes editing multiple services #16
Proposed Changes
EditMetadata
toEditServices
tabEditComputeDataset
tab removed and fields moved toEditServices
tabdefaultDatatokenCap
to app.config from publish flow. It is used also in edit flow (add service).type
in Edit Metadata - just for viewing, not editableoffchain
record which is not ready yet - ocean-node issuegetPaymentCollector
functionsetMinterToPublisher
andsetMinterToDispenser
functionsInputElement
type numberBoxSelection
checked value when multiple of them on a same pageTODOs
type
,file
andserviceEndpoint
.compute
checkout editingServiceComputeOptions
. Make sure to understand this ambiguity between what ocean.js is saying and what docs are saying about [] vs null vs undefinedTODOs (not related to editing services)
check datatoken templateIndex - do we work with the correct one? Do we want to support all?fixed here Fix publishing #44links
editing in Edit Metadata whether it works as it should.algorithm
field in metadata (MetadataAlgorithm
). Also have a look intoconsumerParameters
. They are editable on service level. But should they be editable on metadata level as well (inMetadataAlgorithm
type there are actually 2 places forconsumerParameters
)? I don't understand the use there.