Skip to content

Commit

Permalink
notice-types: Add review section for result notices (TEDEFO-3705)
Browse files Browse the repository at this point in the history 
Also include other small changes.
  • Loading branch information
@bertrand-lorentz
bertrand-lorentz committed Oct 1, 2024
1 parent bfca741 commit 4be7511
Show file tree
Hide file tree
Showing 15 changed files with 3,721 additions and 263 deletions.
418 changes: 309 additions & 109 deletions notice-types/29.json
View file

Large diffs are not rendered by default.

311 changes: 309 additions & 2 deletions notice-types/30.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"ublVersion" : "2.3",
"sdkVersion" : "1.13.0-SNAPSHOT",
"metadataDatabase" : {
"version" : "1.12.359",
"createdOn" : "2024-09-20T13:39:57"
"version" : "1.12.401",
"createdOn" : "2024-10-01T13:17:56"
},
"noticeId" : "30",
"metadata" : [ {
Expand Down Expand Up @@ -4705,7 +4705,314 @@
} ]
} ]
} ]
}, {
"id" : "GR-LotResult-EED",
"contentType" : "group",
"nodeId" : "ND-EEDLotResult",
"displayType" : "GROUP",
"description" : "Overall information about the bought assets under EED: Product type, category and quantity",
"_label" : "group|name|ND-EEDLotResult",
"content" : [ {
"id" : "GR-LotResult-EED-Information",
"contentType" : "group",
"nodeId" : "ND-EEDInformationLotResult",
"displayType" : "GROUP",
"description" : "EED related information for a given LotResult",
"_label" : "group|name|ND-EEDInformationLotResult",
"content" : [ {
"id" : "GR-LotResult-EED-AssetDetails",
"contentType" : "group",
"nodeId" : "ND-EEDProcurementDetailsLotResult",
"displayType" : "GROUP",
"description" : "EED detailed information for a given procured asset of a LotResult",
"_label" : "group|name|ND-EEDProcurementDetailsLotResult",
"_repeatable" : true,
"content" : [ {
"id" : "BT-811(a)-LotResult",
"contentType" : "field",
"displayType" : "COMBOBOX",
"description" : "EED List (Basis)",
"_label" : "field|name|BT-811(a)-LotResult"
}, {
"id" : "BT-811(b)-LotResult",
"contentType" : "field",
"displayType" : "COMBOBOX",
"description" : "EED List (Item)",
"_label" : "field|name|BT-811(b)-LotResult"
}, {
"id" : "GR-LotResult-EED-AssetLabel",
"contentType" : "group",
"nodeId" : "ND-EEDAssetLabel",
"displayType" : "GROUP",
"description" : "EED label for a given procured asset of a LotResult",
"_label" : "group|name|ND-EEDAssetLabel",
"content" : [ {
"id" : "BT-812-LotResult",
"contentType" : "field",
"displayType" : "COMBOBOX",
"description" : "Energy Efficiency Label",
"_label" : "field|name|BT-812-LotResult"
} ]
}, {
"id" : "GR-LotResult-EED-AssetQuantity",
"contentType" : "group",
"nodeId" : "ND-EEDAssetQuantity",
"displayType" : "GROUP",
"description" : "EED Quantity for a given procured asset of a LotResult",
"_label" : "group|name|ND-EEDAssetQuantity",
"content" : [ {
"id" : "BT-815-LotResult",
"contentType" : "field",
"displayType" : "TEXTBOX",
"description" : "Energy Efficiency Quantity",
"_label" : "field|name|BT-815-LotResult"
} ]
}, {
"id" : "GR-LotResult-EED-Consumption",
"contentType" : "group",
"nodeId" : "ND-EEDConsumption",
"displayType" : "GROUP",
"description" : "EED yearly Energy Consumption for a given procured asset of a LotResult",
"_label" : "group|name|ND-EEDConsumption",
"content" : [ {
"id" : "BT-813-LotResult",
"contentType" : "field",
"displayType" : "TEXTBOX",
"description" : "Energy Consumption in kWh/year",
"_label" : "field|name|BT-813-LotResult"
}, {
"id" : "OPT-080-LotResult",
"contentType" : "field",
"displayType" : "COMBOBOX",
"description" : "Consumption Metric",
"_label" : "field|name|OPT-080-LotResult",
"_presetValue" : "nrg-con-yr"
} ]
}, {
"id" : "GR-LotResult-EED-EnergySavings",
"contentType" : "group",
"nodeId" : "ND-EEDSavings",
"displayType" : "GROUP",
"description" : "EED yearly Energy Savings for a given procured asset of a LotResult",
"_label" : "group|name|ND-EEDSavings",
"content" : [ {
"id" : "BT-814-LotResult",
"contentType" : "field",
"displayType" : "TEXTBOX",
"description" : "Energy Savings in kWh/year",
"_label" : "field|name|BT-814-LotResult"
}, {
"id" : "OPT-081-LotResult",
"contentType" : "field",
"displayType" : "COMBOBOX",
"description" : "Savings Metric",
"_label" : "field|name|OPT-081-LotResult",
"_presetValue" : "nrg-sav-yr"
} ]
} ]
} ]
} ]
} ]
} ]
} ]
}, {
"id" : "GR-Review",
"contentType" : "group",
"nodeId" : "ND-ReviewRequests",
"displayType" : "SECTION",
"description" : "Information about Requested Reviews and their associated statuses",
"_label" : "group|name|ND-ReviewRequests",
"content" : [ {
"id" : "GR-Review-Status",
"contentType" : "group",
"nodeId" : "ND-ReviewStatus",
"displayType" : "GROUP",
"description" : "Status of submitted Review Requests (ID, Stage, Title, Description, Request, Decision)",
"_label" : "group|name|ND-ReviewStatus",
"_idScheme" : "REV",
"_schemeName" : "review",
"businessEntityId" : "reviewInformation",
"_identifierFieldId" : "BT-804-Review",
"_captionFieldId" : "BT-784-Review",
"_repeatable" : true,
"content" : [ {
"id" : "BT-804-Review",
"contentType" : "field",
"displayType" : "TEXTBOX",
"description" : "Review Technical Identifier",
"_label" : "field|name|BT-804-Review",
"_idScheme" : "REV",
"_schemeName" : "review"
}, {
"id" : "BT-783-Review",
"contentType" : "field",
"displayType" : "COMBOBOX",
"description" : "Review Request or Decision",
"_label" : "field|name|BT-783-Review"
}, {
"id" : "GR-Review-AppealParty",
"contentType" : "group",
"nodeId" : "ND-AppealingParty",
"displayType" : "GROUP",
"description" : "A Party that initiated the Review Request",
"_label" : "group|name|ND-AppealingParty",
"_repeatable" : true,
"content" : [ {
"id" : "BT-808-Review",
"contentType" : "field",
"displayType" : "COMBOBOX",
"description" : "Review Applicant Identifier",
"_label" : "field|name|BT-808-Review",
"_idSchemes" : [ "ORG" ]
} ]
}, {
"id" : "GR-Review-Party",
"contentType" : "group",
"nodeId" : "ND-AppealProcessingParty",
"displayType" : "GROUP",
"description" : "Party dealing with the review at the given process step.",
"_label" : "group|name|ND-AppealProcessingParty",
"content" : [ {
"id" : "BT-807-Review",
"contentType" : "field",
"displayType" : "COMBOBOX",
"description" : "Review Body Identifier",
"_label" : "field|name|BT-807-Review",
"_idSchemes" : [ "ORG" ]
}, {
"id" : "BT-799-ReviewBody",
"contentType" : "field",
"displayType" : "COMBOBOX",
"description" : "Review Body Type",
"_label" : "field|name|BT-799-ReviewBody"
} ]
}, {
"id" : "BT-784-Review",
"contentType" : "field",
"displayType" : "TEXTBOX",
"description" : "Review Identifier",
"_label" : "field|name|BT-784-Review"
}, {
"id" : "BT-785-Review",
"contentType" : "field",
"displayType" : "TEXTBOX",
"description" : "Review Previous Identifier",
"_label" : "field|name|BT-785-Review"
}, {
"id" : "GR-Review-AppealedItem",
"contentType" : "group",
"nodeId" : "ND-AppealedItemReference",
"displayType" : "GROUP",
"description" : "Appealed item",
"_label" : "group|name|ND-AppealedItemReference",
"_repeatable" : true,
"content" : [ {
"id" : "BT-786-Review",
"contentType" : "field",
"displayType" : "TEXTBOX",
"description" : "Review Notice Section Identifier",
"_label" : "field|name|BT-786-Review",
"_idSchemes" : [ "CON", "GLO", "LOT", "ORG", "PAR", "RES", "TEN", "TPA", "TPO", "UBO" ]
} ]
}, {
"id" : "BT-787-Review",
"contentType" : "field",
"displayType" : "TEXTBOX",
"description" : "Review Date",
"_label" : "field|name|BT-787-Review"
}, {
"id" : "BT-788-Review",
"contentType" : "field",
"displayType" : "TEXTAREA",
"description" : "Review Title",
"_label" : "field|name|BT-788-Review"
}, {
"id" : "BT-789-Review",
"contentType" : "field",
"displayType" : "TEXTAREA",
"description" : "Review Description",
"_label" : "field|name|BT-789-Review"
}, {
"id" : "BT-794-Review",
"contentType" : "field",
"displayType" : "TEXTBOX",
"description" : "Review URL",
"_label" : "field|name|BT-794-Review"
}, {
"id" : "GR-Review-Decision",
"contentType" : "group",
"nodeId" : "ND-AppealDecision",
"displayType" : "GROUP",
"description" : "Decision type",
"_label" : "group|name|ND-AppealDecision",
"_repeatable" : true,
"content" : [ {
"id" : "BT-790-Review",
"contentType" : "field",
"displayType" : "COMBOBOX",
"description" : "Review Decision Type",
"_label" : "field|name|BT-790-Review"
} ]
}, {
"id" : "GR-Review-IrregularityType",
"contentType" : "group",
"nodeId" : "ND-AppealIrregularity",
"displayType" : "GROUP",
"description" : "Irregularity type",
"_label" : "group|name|ND-AppealIrregularity",
"_repeatable" : true,
"content" : [ {
"id" : "BT-791-Review",
"contentType" : "field",
"displayType" : "COMBOBOX",
"description" : "Review Irregularity Type",
"_label" : "field|name|BT-791-Review"
} ]
}, {
"id" : "GR-Review-Remedy",
"contentType" : "group",
"nodeId" : "ND-AppealRemedy",
"displayType" : "GROUP",
"description" : "Remedy type",
"_label" : "group|name|ND-AppealRemedy",
"_repeatable" : true,
"content" : [ {
"id" : "BT-792-Review",
"contentType" : "field",
"displayType" : "COMBOBOX",
"description" : "Review Remedy Type",
"_label" : "field|name|BT-792-Review"
} ]
}, {
"id" : "BT-793-Review",
"contentType" : "field",
"displayType" : "TEXTBOX",
"description" : "Review Remedy Value",
"_label" : "field|name|BT-793-Review"
}, {
"id" : "BT-795-Review",
"contentType" : "field",
"displayType" : "TEXTBOX",
"description" : "Review Request Fee",
"_label" : "field|name|BT-795-Review"
}, {
"id" : "BT-796-Review",
"contentType" : "field",
"displayType" : "RADIO",
"description" : "Review Request Withdrawn",
"_label" : "field|name|BT-796-Review"
}, {
"id" : "BT-797-Review",
"contentType" : "field",
"displayType" : "TEXTBOX",
"description" : "Review Request Withdrawn Date",
"_label" : "field|name|BT-797-Review"
}, {
"id" : "BT-798-Review",
"contentType" : "field",
"displayType" : "TEXTAREA",
"description" : "Review Request Withdrawn Reasons",
"_label" : "field|name|BT-798-Review"
} ]
} ]
}, {
Expand Down
Loading

2 comments on commit 4be7511

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'JMH Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.

Benchmark suite Current: 4be7511 Previous: 2df43cb Ratio
eu.europa.ted.eforms.sdk.analysis.SchematronBenchmark.executeValidation ( {"noticeFilename":"16.xml","sdkRootPath":"/home/runner/work/eForms-SDK/eForms-SDK"} ) 10.112634699500001 s/op 8.903712946166666 s/op 1.14

This comment was automatically generated by workflow using github-action-benchmark.

@bertrand-lorentz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance alert was a false alarm: no alert when re-running the benchmark.

Please sign in to comment.