Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website redesign #355

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

gathogojr
Copy link
Contributor

@gathogojr gathogojr commented Aug 11, 2023

This pull request recreates the website redesign PR #348.

PR #348 had been merged to master but was reverted to investigate reasons for the site being broken.
The conditions that contributed to the site being broken after deploying #348 have been mitigated through #357 and #358. It's important however to retest and re-review this PR.

@marabooy
Copy link
Member

marabooy commented Oct 3, 2023

@gathogojr could you share the staging link we can use to test the site if possible

@gathogojr
Copy link
Contributor Author

@gathogojr could you share the staging link we can use to test the site if possible

@marabooy @mikepizzo Redesigned site on staging https://odata-prod-stage.azurewebsites.net/

@gathogojr
Copy link
Contributor Author

One thing I'm concerned about is that the section that is light peach in color (in the middle of the page) appears like a footer:

image

It's only if/after someone scrolls down that they realize there's more content below it:

image

@mikepizzo
Copy link
Member

I agree -- thoughts on how to fix? Is there a better way to frame the Recent Posts?


In reply to: 1748730465

@@ -0,0 +1,20 @@
---
layout: page
title: Tools
Copy link
Member

@mikepizzo mikepizzo Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tools

this page is currently blank.

For whatever reason, it doesn't seem to be finding the tools in site.tools

@@ -3,23 +3,34 @@
title: Blog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blog

The latest blog shown on the page is from 2018, which makes the technology look old and unused. As the comment says we have been adding blogs to another site. There are a couple interesting blogs we can add (OASIS releases Data Aggregation extensions, use of OData by BurnRate, etc.).

I wonder, though, if there's a way to bring the blogs from the other site inline here.

<div class="jumbotron">
<h2>Information on how to contribute has been moved to the footer on every page</h2>
<a href="/"><h3><span class="glyphicon glyphicon-arrow-right"></span> Go home</h3></a>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to keep these legacy_pages in the repo?

<svg xmlns="http://www.w3.org/2000/svg" width="1em" height="1em" fill="white" class="bi bi-github" viewBox="0 0 16 16">
<path d="M8 0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59.4.07.55-.17.55-.38 0-.19-.01-.82-.01-1.49-2.01.37-2.53-.49-2.69-.94-.09-.23-.48-.94-.82-1.13-.28-.15-.68-.52-.01-.53.63-.01 1.08.58 1.23.82.72 1.21 1.87.87 2.33.66.07-.52.28-.87.51-1.07-1.78-.2-3.64-.89-3.64-3.95 0-.87.31-1.59.82-2.15-.08-.2-.36-1.02.08-2.12 0 0 .67-.21 2.2.82.64-.18 1.32-.27 2-.27.68 0 1.36.09 2 .27 1.53-1.04 2.2-.82 2.2-.82.44 1.1.16 1.92.08 2.12.51.56.82 1.27.82 2.15 0 3.07-1.87 3.75-3.65 3.95.29.25.54.73.54 1.48 0 1.07-.01 1.93-.01 2.2 0 .21.15.46.55.38A8.012 8.012 0 0 0 16 8c0-4.42-3.58-8-8-8z" />
</svg>
<p><a href="https://github.com/OData">OData Org</a></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/OData

this should probably be https://github.com/OData/odataorg.github.io, which is the specific repo for odata.org.

<div class="row" style="margin: 4rem 0 6rem 0">
<h3 style="text-align:center; padding:2rem;">Featured Tools</h3>
<div class="items-container centered" style="flex-wrap:wrap; align-content:space-between">
{% assign featuredTools = site.tools | where: "featured", "true" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we currently don't have any tools marked "featured", so this section is blank. If it's blank, we should hide it (looks bad to have "Featured Tools" with nothing.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants