[MIG] stock_picking_invoice_link: Migration to 18.0 #1752

carlosdynapps · 2024-10-31T15:29:11Z

No description provided.

… a SyntaxError

…iew. Minor coding style improvements.

partially by creating i18n folder first

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

picking.invoice_id for every stock move.

…re blocked by this constraint

… is cancelled its pickings go back to "to2invoiced" state * If a cancelled invoice goes back again to draft, its pickings are marked as invoiced to avoid invoicing twice * Not able to erase an invoice with pickings not cancelled * Tests stock_picking_invoice_link: unlink improved * enable erasing when invoice is in state 'draft' or 'cancel' * if invoice is in state 'draft', not cancelled picking will be invoiceable

… references For dropshipping pickings with module stock_dropshipping_dual_invoice, you generate two invoices for the same picking, so the many2one only reflects the last generated invoice. With this change, now both are linked.

…ing flow

…#296) Previous migration did not keep the business functionality of the previous module. Link from invoice to picking must link only related delivery and not all deliveries in case of partial delivery

avoiding 'product.service_delivery' because not useful in tests and correctly handled as service by 10.0 tests

Currently translated at 100.0% (12 of 12 strings) Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_invoice_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_invoice_link/pt_BR/

Currently translated at 100.0% (18 of 18 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_invoice_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_invoice_link/es/

Currently translated at 100.0% (18 of 18 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_invoice_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_invoice_link/it/

Currently translated at 100.0% (18 of 18 strings) Translation: stock-logistics-workflow-17.0/stock-logistics-workflow-17.0-stock_picking_invoice_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-17-0/stock-logistics-workflow-17-0-stock_picking_invoice_link/it/

Currently translated at 100.0% (18 of 18 strings) Translation: stock-logistics-workflow-17.0/stock-logistics-workflow-17.0-stock_picking_invoice_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-17-0/stock-logistics-workflow-17-0-stock_picking_invoice_link/de/

In c332869 a new computed field was introduced to show the count of a move's related pickings. But it was made stored, which is needless for this kind of field and adds a huge overhead when migrating from big DBs from previous versions. With this commit: - We drop the storing of this field which is meant to play a UI role. - We rename the field to picking count, as a more precise nomenclature. TT46020

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-17.0/stock-logistics-workflow-17.0-stock_picking_invoice_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-17-0/stock-logistics-workflow-17-0-stock_picking_invoice_link/

Currently translated at 100.0% (18 of 18 strings) Translation: stock-logistics-workflow-17.0/stock-logistics-workflow-17.0-stock_picking_invoice_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-17-0/stock-logistics-workflow-17-0-stock_picking_invoice_link/it/

NachoAlesLopez

Functionally it works perfectly fine. I've left some notes regarding small details in code

NachoAlesLopez · 2024-11-11T09:14:34Z

stock_picking_invoice_link/models/account_move.py

+        for record, vals in zip(self, vals_list, strict=False):
+            if (
+                self.env.context.get("force_copy_stock_moves")
+                and "move_line_ids" not in vals
+            ):


This condition can be placed outside the for loop, which can save a bit of time if there are many records.

Suggested change

for record, vals in zip(self, vals_list, strict=False):

if (

self.env.context.get("force_copy_stock_moves")

and "move_line_ids" not in vals

):

if self.env.context.get("force_copy_stock_moves"):

for record, vals in zip(self, vals_list, strict=False):

if "move_line_ids" not in vals:

NachoAlesLopez · 2024-11-11T09:15:48Z

stock_picking_invoice_link/models/account_move.py

+                self.env.context.get("force_copy_stock_moves")
+                and "move_line_ids" not in vals
+            ):
+                vals["move_line_ids"] = [(6, 0, record.move_line_ids.ids)]


Can you replace this set operation with a Command?

Suggested change

vals["move_line_ids"] = [(6, 0, record.move_line_ids.ids)]

vals["move_line_ids"] = Command.set(record.move_line_ids.ids)

[MIG] stock_picking_invoice_link: Migration to 18.0 [MIG] stock_picking_invoice_link: Migration to 18.0 [MIG] stock_picking_invoice_link: Migration to 18.0 [MIG] stock_picking_invoice_link: Migration to 18.0 [MIG] stock_picking_invoice_link: Migration to 18.0

luc-adhoc

functional review

eLBati and others added 30 commits October 31, 2024 15:32

[add] stock_picking_invoice_link

05d0da3

[FIX] missing comma in __openerp__.py preventing server to start with…

8813199

… a SyntaxError

[ADD] handling _invoice_line_hook

271f1a8

Add one2many from invoice to pickings and display it in the invoice v…

360e340

…iew. Minor coding style improvements.

autopep8 lint

f46aaf8

Port module stock_picking_invoice_link to v8

12d4b74

create translation files (template and german)

0066ae3

partially by creating i18n folder first

[ADD]stock_picking_invoice_link: Added spanish translation.

82de885

Add OCA as author of OCA addons

7c79c77

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

[FIX] removing wrong method _create_invoice_from_picking and values

7caefed

picking.invoice_id for every stock move.

[FIX] When trying to duplicate an invoice with related pickings you a…

557ae8c

…re blocked by this constraint

Update copyright year

de74615

[UPD] prefix versions with 8.0

6ce311a

[MIG] Make modules uninstallable

acb374a

OCA Transbot updated translations from Transifex

06821c1

[IMP] stock_picking_invoice_link: Refactoring based on new 9.0 invoic…

64ef32b

…ing flow

OCA Transbot updated translations from Transifex

87cf217

FIX link invoice view on pickings

2bf12d4

[9.0] stock_picking_invoice_link: redo migration from 8.0 to 9.0 (OCA…

b9e7719

…#296) Previous migration did not keep the business functionality of the previous module. Link from invoice to picking must link only related delivery and not all deliveries in case of partial delivery

[MIG] stock_picking_invoice_link: Migration to 10.0

abcfa5b

avoiding 'product.service_delivery' because not useful in tests and correctly handled as service by 10.0 tests

[IMP] stock_picking_invoice_link: Review changes

0eb3552

[MIG] stock_picking_invoice_link: Migration to 11.0

adf5701

[FIX] stock_picking_invoice_link: refund moves

9e12dca

[FIX] stock_picking_invoice_link: typo in readme

50d1f0f

[12.0][MIG] stock_picking_invoice_link module

2eac2cb

[IMP] stock_picking_invoice_link: black, isort

7725539

[MIG] stock_picking_invoice_link: Migration to 13.0

559f237

Ivorra78 and others added 23 commits October 31, 2024 15:32

[IMP] stock_picking_invoice_link: pre-commit auto fixes

db2b25a

[MIG] stock_picking_invoice_link: Migration to 17.0

d11c729

[UPD] Update stock_picking_invoice_link.pot

96a3d6f

[BOT] post-merge updates

a713575

[FIX] stock_picking*: Pre-commit fixes

80b20ff

[BOT] post-merge updates

db00372

[UPD] Update stock_picking_invoice_link.pot

8193de9

[BOT] post-merge updates

4b69730

[FIX] stock_picking_invoice_link: Avoid inconsistent computes

eac39fd

[BOT] post-merge updates

e0d7a8a

[FIX] stock_picking_invoice_link: development status

af74795

[BOT] post-merge updates

f1e638a

[FIX] stock_picking_invoice_link: Avoid doble compute picking_count

530d7c6

[BOT] post-merge updates

ed1f7c3

[IMP] stock_picking_invoice_link: Fix argument in reverse_moves

2c4685c

[BOT] post-merge updates

a997edf

carlosdynapps force-pushed the 18.0-mig-stock_picking_invoice_link branch 3 times, most recently from 1edda2f to d77646b Compare October 31, 2024 16:30

NachoAlesLopez reviewed Nov 11, 2024

View reviewed changes

carlosdynapps force-pushed the 18.0-mig-stock_picking_invoice_link branch from 843ae47 to 44aa4e4 Compare November 12, 2024 09:57

luc-adhoc approved these changes Nov 12, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] stock_picking_invoice_link: Migration to 18.0 #1752

[MIG] stock_picking_invoice_link: Migration to 18.0 #1752

carlosdynapps commented Oct 31, 2024

NachoAlesLopez left a comment

NachoAlesLopez Nov 11, 2024

NachoAlesLopez Nov 11, 2024

luc-adhoc left a comment

	vals["move_line_ids"] = [(6, 0, record.move_line_ids.ids)]
	vals["move_line_ids"] = Command.set(record.move_line_ids.ids)

[MIG] stock_picking_invoice_link: Migration to 18.0 #1752

Are you sure you want to change the base?

[MIG] stock_picking_invoice_link: Migration to 18.0 #1752

Conversation

carlosdynapps commented Oct 31, 2024

NachoAlesLopez left a comment

Choose a reason for hiding this comment

NachoAlesLopez Nov 11, 2024

Choose a reason for hiding this comment

NachoAlesLopez Nov 11, 2024

Choose a reason for hiding this comment

luc-adhoc left a comment

Choose a reason for hiding this comment