-
-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] purchase_stock_picking_invoice_link: Migration to 16.0 #1198
[16.0][MIG] purchase_stock_picking_invoice_link: Migration to 16.0 #1198
Conversation
…in stock_picking_invoice_link
Steps to reproduce the problem: - Create a sales order with Dropshipping route. - Confirm the sale order. - Confirm the purchase order and validate the DS picking. - Invoice the sales order. - Invoice the purchase order. Current behavior: The vendor bill is not linked to the DS picking Expected behavior: It's linked. That's because 2 problems: - Current algorithm looks for existing invoices linked to the picking for discarding double links, but it's not having into account that such invoices can be customer ones. We simply filter for vendor bills in the algorithm to fix it. Twin for the customer part already done in OCA#1036. - The location filter must use the supplier location as reference, not the internal one, as in DS, there's no internal location. TT38628
…ckorders Before this patch, when we receive products in a backorder and the other quantities received where invoiced yet, the picking of the backorder will be related to the invoice created for the other quantities. With this patch, this situation will just happen when the invoicing policy of the product is based on quantities purchased. Steps to reproduce the problem: 1. Create a purchase order buying 10 units of some stockable product 2. Receive 8 units of the product 3. Create back order 4. Invoice the received quantity (8 units) 5. Receive 2 units of the product in the created back order 6. You will see that the back order picking is related to the invoice with 8 units
…nvoice If we make partial invoices, we need that all partial invoices were linked to the pickings related. Steps to reproduce the problem: 1. Create a purchase order buying 10 units of some stockable product 2. Receive all 3. Create new invoice, invoicing just 8 units (This invoice will be linked to the picking) 4. Create new invoice, invoicing the remaining quantity 5. The invoice with 2 units won't be linked to the picking x
We have done functional tests and it works correctly. |
/ocabot migration purchase_stock_picking_invoice_link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
purchase_stock_picking_invoice_link/tests/test_purchase_stock_picking_invoice_link.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
This PR has the |
/ocabot merge nobump |
On my way to merge this fine PR! |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1198-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 25701a0. Thanks a lot for contributing to OCA. ❤️ |
Issue: #1101