Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] base_user_role: Adding alert in user when role is used #296

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

CRogos
Copy link

@CRogos CRogos commented Jun 21, 2024

cherry pick of #273

@dreispt

@OCA-git-bot
Copy link
Contributor

Hi @novawish, @jcdrubay, @sebalix,
some modules you are maintaining are being modified, check this out!

@CRogos CRogos marked this pull request as draft June 21, 2024 20:25
@CRogos CRogos marked this pull request as ready for review June 21, 2024 20:34
@CRogos CRogos changed the title [16.0][IMP] base_user_role: Adding alert in user when role is used [17.0][IMP] base_user_role: Adding alert in user when role is used Jul 3, 2024
Copy link

@MohamedOsman7 MohamedOsman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CRogos CRogos mentioned this pull request Jul 8, 2024
10 tasks
@CRogos
Copy link
Author

CRogos commented Jul 8, 2024

@rven could you review? Forward migration of a change in v16.

@CRogos
Copy link
Author

CRogos commented Jul 10, 2024

@pedrobaeza could you also review this. This change was made on v16 after it has been migrated to v17, therefore this commit is missing in v17.

@pedrobaeza pedrobaeza added this to the 17.0 milestone Jul 10, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same as v16:

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-296-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2c39bdd into OCA:17.0 Jul 10, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 214e386. Thanks a lot for contributing to OCA. ❤️

@CRogos CRogos deleted the 17.0-port-base_user_role branch July 10, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants