Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] base_user_role_history: Migration to 17.0 #291

Merged
merged 12 commits into from
Aug 27, 2024

Conversation

MohamedOsman7
Copy link

No description provided.

@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-base_user_role_history branch 2 times, most recently from de485b4 to 3651858 Compare June 4, 2024 18:09
Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding/removing a role to a user, the history entry is created.
When adding/removing a user from a role, no entry is created. (same bug in v16)
image

@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-base_user_role_history branch 2 times, most recently from 439919b to b7ac628 Compare June 18, 2024 14:53
@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-base_user_role_history branch from b7ac628 to 79d99df Compare June 24, 2024 10:57
@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-base_user_role_history branch from 79d99df to cb36136 Compare July 6, 2024 22:59
@CRogos CRogos force-pushed the 17.0-mig-base_user_role_history branch 2 times, most recently from 06e195f to 1b3c69a Compare July 8, 2024 14:25
@CRogos CRogos force-pushed the 17.0-mig-base_user_role_history branch from 1b3c69a to 6e671c0 Compare July 8, 2024 20:38
@CRogos CRogos mentioned this pull request Jul 8, 2024
10 tasks
@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-base_user_role_history branch from 6e671c0 to cb36136 Compare July 9, 2024 09:53
@CRogos CRogos force-pushed the 17.0-mig-base_user_role_history branch from cb36136 to 6e671c0 Compare July 9, 2024 10:06
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CRogos
Copy link

CRogos commented Aug 27, 2024

@pedrobaeza could you merge?

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-291-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 29b5a18 into OCA:17.0 Aug 27, 2024
11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1abb38f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.