[16.0][IMP] base_global_discount: Add check global discount in product #221

Rferri44-S73 · 2023-06-22T06:42:27Z

Add check global discount in products

QuocDuong1306

lgtm

cyrilmanuel

LGTM

rafaelbn · 2023-09-01T13:11:41Z

Hello! :-)

This module is base_global_discount and not base_config_discount

This should be reviewed by @ferran-S73 @rousseldenis or @pedrobaeza

Thank you!

ferran-S73 · 2023-09-04T06:09:13Z

Hi @rafaelbn since the original owner of the PR doesn't work here anymore I fixed the commit name myself. As for the changes in here LGTM

ferran-S73 · 2023-09-04T06:09:47Z

I guess the title of the PR has to be changed by a maintainer

simahawk

LG overall, just a quick code review tho.

TODO:

rollback module version
remove odoo version from commit

@pedrobaeza anyone from Tecnativa to review?

base_global_discount/__manifest__.py

pedrobaeza

I think in a business perspective more logical to use a negative flag: don't apply global discount, although the formula I prefer is to add a m2m in each global discount to exclude some products from them.

base_global_discount/models/product_product.py

ferran-S73 · 2023-10-18T11:17:33Z

@simahawk @pedrobaeza changes done, I haven't changed the field itself as to no disrupt our clients that are already using this feature

pedrobaeza · 2023-10-18T11:25:33Z

Well, you can put migration scripts, but keeping weird fields in the definitive version is not desirable.

simahawk · 2023-10-18T14:18:45Z

Well, you can put migration scripts, but keeping weird fields in the definitive version is not desirable.

I agree. In this case you are allowed to change the version manually and add a pre/post migrate script to adapt existing installations.

simahawk · 2023-11-16T09:12:37Z

@Rferri44-S73 ping

ferran-S73 · 2023-11-16T09:53:54Z

@Rferri44-S73 ping

Hi @simahawk , I'm sorry I haven't been able to update this pr as requested. I have this in my todo list and will eventually apply the suggestions you and @pedrobaeza gave me. Sorry for the inconvenience

github-actions · 2024-03-17T12:14:24Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

OCA/server-backend#221 (review)

cyrilmanuel · 2024-03-26T10:40:25Z

Hi @Rferri44-S73 little ping have you the time to work on it ? :)

OCA/server-backend#221 (review)

carolinafernandez-tecnativa · 2024-04-01T18:29:53Z

Hi, could you please rebase? Thanks!

OCA/server-backend#221 (review)

dreispt · 2024-05-11T17:02:27Z

This is blocking OCA/account-invoicing#1338
What can be done to move forward?

carolinafernandez-tecnativa

LGTM, Thanks!

carolinafernandez-tecnativa · 2024-05-15T16:30:27Z

@simahawk can we proceed to merge? this blocks OCA/account-invoicing#1338

pedrobaeza · 2024-05-17T07:00:49Z

base_global_discount/models/product_product.py

@@ -0,0 +1,15 @@
+# Copyright 2023 Studio73 - Rafa Ferri <[email protected]>
+# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).


Suggested change

# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).

# License AGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).

pedrobaeza · 2024-05-17T07:00:57Z

base_global_discount/models/product_template.py

@@ -0,0 +1,36 @@
+# Copyright 2023 Studio73 - Rafa Ferri <[email protected]>
+# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).


Suggested change

# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).

# License AGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).

pedrobaeza · 2024-05-17T07:36:49Z

Summarizing this one, apart from my latest comments, we are talking about not putting a flag in the product, that is very disrupting, but add a m2m in the global discounts for including or excluding. That way, you get even more granularity.

ferran-S73 · 2024-05-20T15:31:07Z

Hi @pedrobaeza I've updated this PR adding a negative flag on the products as accorded on OCA/account-invoicing#1725 (comment)

I have also updated th following PRs that depend on this one

Hope everything is alright now!

pedrobaeza

OK, I think it's good enough

/ocabot merge minor

OCA-git-bot · 2024-05-23T17:24:29Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-221-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot · 2024-05-23T17:28:53Z

Congratulations, your PR was merged at b835bae. Thanks a lot for contributing to OCA. ❤️

OCA/server-backend#221 (review)

This was referenced Jun 28, 2023

[MIG] account_global_discount: 16.0 OCA/account-invoicing#1338

Closed

[16.0][MIG] sale_global_discount: 16.0 OCA/sale-workflow#2343

Merged

QuocDuong1306 approved these changes Aug 28, 2023

View reviewed changes

cyrilmanuel approved these changes Aug 31, 2023

View reviewed changes

OCA-git-bot added the approved label Aug 31, 2023

ferran-S73 force-pushed the 16.0-add-base_config_discount branch from ff1e9db to 5304cf5 Compare September 4, 2023 06:07

simahawk changed the title ~~[16.0][IMP] base_config_discount: Add check global discount in product~~ [16.0][IMP] base_global_discount: Add check global discount in product Oct 9, 2023

simahawk requested changes Oct 9, 2023

View reviewed changes

base_global_discount/__manifest__.py Outdated Show resolved Hide resolved

OCA-git-bot removed the approved label Oct 9, 2023

pedrobaeza added this to the 16.0 milestone Oct 9, 2023

pedrobaeza reviewed Oct 9, 2023

View reviewed changes

base_global_discount/models/product_product.py Outdated Show resolved Hide resolved

ferran-S73 force-pushed the 16.0-add-base_config_discount branch from 5304cf5 to bd92598 Compare October 18, 2023 11:15

miguel-S73 mentioned this pull request Mar 15, 2024

[MIG] base_global_discount: 17.0 #275

Merged

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 17, 2024

miguel-S73 added a commit to Studio73/sale-workflow that referenced this pull request Mar 21, 2024

[IMP] sale_order_general_discount: change name field and logical

c88e882

OCA/server-backend#221 (review)

miguel-S73 mentioned this pull request Mar 21, 2024

[17.0][MIG] sale_order_general_discount: 17.0 OCA/sale-workflow#3030

Merged

miguel-S73 added a commit to Studio73/sale-workflow that referenced this pull request Mar 21, 2024

[IMP] sale_order_general_discount: change name field and logical

56b038f

OCA/server-backend#221 (review)

miguel-S73 added a commit to Studio73/sale-workflow that referenced this pull request Mar 27, 2024

[IMP] sale_order_general_discount: change name field and logical

c0defa4

OCA/server-backend#221 (review)

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 31, 2024

miguel-S73 added a commit to Studio73/sale-workflow that referenced this pull request Apr 3, 2024

[IMP] sale_order_general_discount: change name field and logical

e2c2fb4

OCA/server-backend#221 (review)

ioans73 force-pushed the 16.0-add-base_config_discount branch from bd92598 to 52d772d Compare April 26, 2024 07:50

carolinafernandez-tecnativa approved these changes May 15, 2024

View reviewed changes

pedrobaeza reviewed May 17, 2024

View reviewed changes

pedrobaeza mentioned this pull request May 17, 2024

[16.0][MIG] account_global_discount: Migration to 16.0 OCA/account-invoicing#1724

Merged

ferran-S73 force-pushed the 16.0-add-base_config_discount branch from 52d772d to f1eb3c9 Compare May 20, 2024 06:51

ferran-S73 mentioned this pull request May 20, 2024

[16.0][IMP] account_global_discount: exclude products from global disc OCA/account-invoicing#1725

Merged

ferran-S73 force-pushed the 16.0-add-base_config_discount branch from f1eb3c9 to dd45bc7 Compare May 20, 2024 15:27

[16.0][IMP] base_global_discount: Add flag in product to bypass discount

d160ff9

ferran-S73 force-pushed the 16.0-add-base_config_discount branch from dd45bc7 to d160ff9 Compare May 20, 2024 15:28

pedrobaeza approved these changes May 23, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label May 23, 2024

OCA-git-bot merged commit aac7ffc into OCA:16.0 May 23, 2024
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 23, 2024

ferran-S73 deleted the 16.0-add-base_config_discount branch May 24, 2024 06:14

adrip-s73 pushed a commit to Studio73/sale-workflow that referenced this pull request Jul 31, 2024

[IMP] sale_order_general_discount: change name field and logical

0c8f381

OCA/server-backend#221 (review)

adrip-s73 added a commit to Studio73/sale-workflow that referenced this pull request Aug 6, 2024

[IMP] sale_order_general_discount: change name field and logical

0f8e50e

OCA/server-backend#221 (review)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][IMP] base_global_discount: Add check global discount in product #221

[16.0][IMP] base_global_discount: Add check global discount in product #221

Rferri44-S73 commented Jun 22, 2023

QuocDuong1306 left a comment

cyrilmanuel left a comment

rafaelbn commented Sep 1, 2023

ferran-S73 commented Sep 4, 2023

ferran-S73 commented Sep 4, 2023

simahawk left a comment

pedrobaeza left a comment

ferran-S73 commented Oct 18, 2023

pedrobaeza commented Oct 18, 2023

simahawk commented Oct 18, 2023

simahawk commented Nov 16, 2023

ferran-S73 commented Nov 16, 2023

github-actions bot commented Mar 17, 2024

cyrilmanuel commented Mar 26, 2024 •

edited

Loading

carolinafernandez-tecnativa commented Apr 1, 2024

dreispt commented May 11, 2024

carolinafernandez-tecnativa left a comment

carolinafernandez-tecnativa commented May 15, 2024

pedrobaeza May 17, 2024

pedrobaeza May 17, 2024

pedrobaeza commented May 17, 2024

ferran-S73 commented May 20, 2024 •

edited

Loading

pedrobaeza left a comment

OCA-git-bot commented May 23, 2024

OCA-git-bot commented May 23, 2024

		@@ -0,0 +1,15 @@
		# Copyright 2023 Studio73 - Rafa Ferri <[email protected]>
		# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).

	# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).
	# License AGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).

		@@ -0,0 +1,36 @@
		# Copyright 2023 Studio73 - Rafa Ferri <[email protected]>
		# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).

[16.0][IMP] base_global_discount: Add check global discount in product #221

[16.0][IMP] base_global_discount: Add check global discount in product #221

Conversation

Rferri44-S73 commented Jun 22, 2023

QuocDuong1306 left a comment

Choose a reason for hiding this comment

cyrilmanuel left a comment

Choose a reason for hiding this comment

rafaelbn commented Sep 1, 2023

ferran-S73 commented Sep 4, 2023

ferran-S73 commented Sep 4, 2023

simahawk left a comment

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

ferran-S73 commented Oct 18, 2023

pedrobaeza commented Oct 18, 2023

simahawk commented Oct 18, 2023

simahawk commented Nov 16, 2023

ferran-S73 commented Nov 16, 2023

github-actions bot commented Mar 17, 2024

cyrilmanuel commented Mar 26, 2024 • edited Loading

carolinafernandez-tecnativa commented Apr 1, 2024

dreispt commented May 11, 2024

carolinafernandez-tecnativa left a comment

Choose a reason for hiding this comment

carolinafernandez-tecnativa commented May 15, 2024

pedrobaeza May 17, 2024

Choose a reason for hiding this comment

pedrobaeza May 17, 2024

Choose a reason for hiding this comment

pedrobaeza commented May 17, 2024

ferran-S73 commented May 20, 2024 • edited Loading

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented May 23, 2024

OCA-git-bot commented May 23, 2024

cyrilmanuel commented Mar 26, 2024 •

edited

Loading

ferran-S73 commented May 20, 2024 •

edited

Loading