Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] sale_order_secondary_unit: Migration to version 17.0 #3207

Closed
wants to merge 4 commits into from
Closed

[17.0][MIG] sale_order_secondary_unit: Migration to version 17.0 #3207

wants to merge 4 commits into from

Conversation

mmrondon
Copy link

No description provided.

@rousseldenis
Copy link
Contributor

/ocabot migration sale_order_secondary_unit

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 1, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 1, 2024
Open
82 tasks
@rousseldenis
Copy link
Contributor

@mmrondon Thank you for this.

In order to review efficiently, could you point the depending PR in this description ?

Moreover, you can add the dependency here in order to test it functionally: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

@rov-adhoc rov-adhoc mentioned this pull request Jul 16, 2024
Open
@mmrondon
Copy link
Author

Depending PR:
[1560] [17.0][MIG] product_secondary_unit product-attribute#1560

@mmrondon mmrondon force-pushed the 17.0-mig-sale_order_secondary_unit branch 3 times, most recently from 0a5baa5 to 11626a5 Compare July 16, 2024 22:26
@mmrondon mmrondon force-pushed the 17.0-mig-sale_order_secondary_unit branch from 11626a5 to 7d1dfe7 Compare July 24, 2024 00:23
@rov-adhoc
Copy link

@mmrondon Hey! The PR dependency #1560 has already been merged. Could you please rebase this PR?

Thanks in advance.

Best regards,

@rousseldenis
Copy link
Contributor

@mmrondon

@mmrondon mmrondon force-pushed the 17.0-mig-sale_order_secondary_unit branch 2 times, most recently from 176d1ce to e23e245 Compare September 17, 2024 13:20
@mmrondon mmrondon force-pushed the 17.0-mig-sale_order_secondary_unit branch from e23e245 to 7750261 Compare September 25, 2024 14:42
@rov-adhoc
Copy link

@mmrondon Hey! Can you please check the failing test of coverage? There are some lines that are not covered by the tests.
Thanks in advance!!

OCA-git-bot and others added 3 commits October 7, 2024 16:36
@OCA-git-bot @mmrondon
[BOT] post-merge updates
fed9a6f 
[11.0][NEW] sale_order_secondary_unit: New module for sale in a secondary product unit

[11.0][FIX] sale_order_secondary_unit: define sale secondary uom in this module instead of product_secondary_unit

[11.0][IMP/FIX] sale_secondary_unit limit secondary uom in order line

Added domain to limit `secondary_uom_id` to the one defined in product template

[11.0][IMP] sale_secondary_unit: Set secondary uom quantity as 1.0 by default

[11.0][IMP] sale_order_secondary_unit: Add security group

[11.0][IMP] sale_order_secondary_unit: add secondary unit to sale report

Added translation using Weblate (German)

[MIG] sale_order_secondary_unit: Migration to 12.0

[MIG] migrate sale_order_secondary_unit from 12.0 to 13.0

[MIG] sale_order_secondary_unit: Migration to 14.0

[FIX] code refactor

code refactor update

add secondary price unit

[FIX] ZeroDivisionError when qty is null

[IMP] sale_order_secondary_unit: Add name to th/td element + span (improve inheritance).
TT36255

[MIG] sale_order_secondary_unit: Migration to 15.0

[FIX] sale_order_secondary_unit: Fix variant grid matrix usage

[UPD] Update sale_order_secondary_unit.pot

[UPD] README.rst

[FIX] sale_order_secondary_unit: Fix incorrect header position inheritance
TT40001

sale_order_secondary_unit 15.0.1.1.0

[MIG] sale_stock_secondary_unit: Migration to v15.0

[UPD] README.rst

[FIX] sale_order_secondary_unit: Make test resilient

As the test should only test that no change on the UoM quantity is done
when modifying the secondary unit, we remember the existing quantity and
compare it later with the final value, instead of testing against a
fixed value, so any interaction with other modules don't interfere.

sale_order_secondary_unit 15.0.1.1.1

[IMP] sale_order_secondary_unit: Add menu for secondary UoM

[UPD] Update sale_order_secondary_unit.pot

[UPD] README.rst

sale_order_secondary_unit 15.0.1.2.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_secondary_unit
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_secondary_unit/

[IMP] sale_order_secondary_unit: Compatibility with product variants
TT40323

[UPD] Update sale_order_secondary_unit.pot

sale_order_secondary_unit 15.0.2.0.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_secondary_unit
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_secondary_unit/

Translated using Weblate (Spanish)

Currently translated at 100.0% (18 of 18 strings)

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_secondary_unit
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_secondary_unit/es/

Added translation using Weblate (Finnish)

Translated using Weblate (Finnish)

Currently translated at 38.8% (7 of 18 strings)

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_secondary_unit
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_secondary_unit/fi/

[UPD] README.rst

[IMP] sale_order_secondary_unit: test performance improvement
- Include context keys for avoiding mail operations overhead.

[BOT] post-merge updates

[MIG] sale_order_secondary_unit: Add migration script to adapt secod uom to variants
TT45597

[IMP] sale_order_secondary_unit: Require secondary_uom_id when secondary_uom_qty is filled

[BOT] post-merge updates
@mmrondon
[MIG] sale_order_secondary_unit: Migration to 17.0
5daf0c0 
[MIG] sale_order_secondary_unit: Fix wrong value for secondary_uom_qty

[IMP] sale_order_secondary_unit: pre-commit auto fixes

[DON'T MERGE] test-requirements.txt

[IMP] sale_order_secondary_unit: Fix test

[IMP] sale_order_secondary_unit: pre-commit auto fixes

[IMP] sale_order_secondary_unit: Fix unit test

[IMP] sale_order_secondary_unit: Fix Odoo test

[MIG] sale_order_secondary_unit: Delete dependency
@mmrondon
[MIG] sale_order_secondary_unit: Add Unit test for product_template
952925d
@mmrondon mmrondon force-pushed the 17.0-mig-sale_order_secondary_unit branch 5 times, most recently from 5861e55 to 2ffb33d Compare October 8, 2024 20:15
@mmrondon mmrondon force-pushed the 17.0-mig-sale_order_secondary_unit branch from 2ffb33d to de4e1d7 Compare October 8, 2024 20:18
@rov-adhoc
Copy link

@mmrondon Thanks for your effort in adding the new test!
@rousseldenis I would like to ask if it's ready now?

@rousseldenis
Copy link
Contributor

@mmrondon You should preserve commits history. See https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

@rov-adhoc
Copy link

@mmrondon Hey! I would like to ask you if you had the possibility to take a look on the document https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

@mmrondon
Copy link
Author

hello @rov-adhoc @rousseldenis Closing this PR, I opened a new one with commit history #3385

@mmrondon mmrondon closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rov-adhoc rov-adhoc rov-adhoc approved these changes

Assignees
No one assigned
Labels
migration needs fixing needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mmrondon @rousseldenis @rov-adhoc @OCA-git-bot