Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] sale_fixed_discount #2507

Merged
merged 21 commits into from
Jun 12, 2023
Merged

[14.0][MIG] sale_fixed_discount #2507

merged 21 commits into from
Jun 12, 2023

Conversation

damdam-s
Copy link
Member

No description provided.

LoisRForgeFlow and others added 21 commits May 11, 2023 16:21
@LoisRForgeFlow @damdam-s
[9.0][ADD] sale_fixed_discount
9ed91ac
@LoisRForgeFlow @damdam-s
[10.0][MIG] sale_fixed_discount
25d9f74
@JordiBForgeFlow @damdam-s
[11.0][mig] sale_fixed_discount
885d89e
@OCA-git-bot @damdam-s
[UPD] README.rst
b1e204f
@MiquelRForgeFlow @damdam-s
[MIG] sale_fixed_discount: Migration to 12.0
e083885
@MiquelRForgeFlow @damdam-s
[IMP] Simplify code
fe7be96
@OCA-git-bot @damdam-s
[UPD] README.rst
552783d
@HviorForgeFlow @damdam-s
[IMP] sale_fixed_discount: black, isort, prettier
6008c4f
@HviorForgeFlow @damdam-s
[MIG] sale_fixed_discount: Migration to 13.0
b6a3d24
@HviorForgeFlow @damdam-s
Not update lines when SO is locked
c465b4d
@OCA-git-bot @damdam-s
[UPD] README.rst
ce7d024
@MiquelRForgeFlow @damdam-s
[UPD] Eficent -> ForgeFlow
c1f26c4
@OCA-git-bot @damdam-s
[UPD] README.rst
cd0a2b8
@dennybiasiolli @damdam-s
[FIX] sale_fixed_discount: using product.group_discount_per_so_line
2165ace 
instead of `sale.group_discount_per_so_line`
@OCA-git-bot @damdam-s
sale_fixed_discount 13.0.1.0.1
52aad10
@skeller1 @damdam-s
[FIX] sale_fixed_discount: remove obsolete colspan calculation
c59a069
@OCA-git-bot @damdam-s
sale_fixed_discount 13.0.1.1.0
d388554
@JordiBForgeFlow @damdam-s
[13.0][sale_fixed_discount] fix sale portal view
38463cc 
The sale order view in the portal was not displaying the fixed discount.
@OCA-git-bot @damdam-s
sale_fixed_discount 13.0.1.1.1
2db659b
@damdam-s
[IMP] sale_fixed_discount: black, isort, prettier
847bab1
@damdam-s
[MIG] sale_fixed_discount: Migration to 14.0
f9f6696
@damdam-s damdam-s force-pushed the 14.0-mig-sale_fixed_discount branch from c7418ae to f9f6696 Compare May 11, 2023 15:59
CRogos
CRogos approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review LGTM

@CRogos CRogos mentioned this pull request May 26, 2023
Closed
ps-tubtim
ps-tubtim approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@ps-tubtim ps-tubtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CRogos
Copy link
Contributor

CRogos commented Jun 12, 2023

@pedrobaeza can you merge?

@pedrobaeza
Copy link
Member

/ocabot migration sale_fixed_discount
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Jun 12, 2023
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-2507-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Apr 27, 2023
Open
88 tasks
@OCA-git-bot
Copy link
Contributor

The migration issue (#1274) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1701.
Perhaps you should check that there is no duplicate work.
CC : @yp-oerp

@OCA-git-bot OCA-git-bot merged commit dfbecbc into OCA:14.0 Jun 12, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ececaca. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps-tubtim ps-tubtim ps-tubtim approved these changes

@CRogos CRogos CRogos approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.