Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] sale_elaboration: Migration to v14 #2203

Merged
merged 21 commits into from
Sep 30, 2022
Merged

[14.0][MIG] sale_elaboration: Migration to v14 #2203

merged 21 commits into from
Sep 30, 2022

Conversation

CarlosRoca13
Copy link
Contributor

cc @Tecnativa TT37689

please @carlosdauden @sergio-teruel review this

sergio-teruel and others added 20 commits September 28, 2022 12:10
@sergio-teruel @CarlosRoca13
[11.0][ADD] sale_elaboration: New module
029a7e1
@sergio-teruel @CarlosRoca13
[11.0][ADD] sale_elaboration: Display elaboration code in picking
b729007
@sergio-teruel @CarlosRoca13
[11.0][ADD] sale_elaboration: Display salesman in line views
547075c
@sergio-teruel @CarlosRoca13
[11.0][FIX] sale_elaboration: Get first elaboration product
5ea8cef
@sergio-teruel @CarlosRoca13
[11.0][IMP] sale_elaboration: Add to invoice line the sale order refe…
51b9c66 
…rence
@pedrobaeza @CarlosRoca13
[IMP] sale_elaboration: Some improvements
63c9f67
@sergio-teruel @CarlosRoca13
[11.0][ADD] sale_elaboration: Add is_elaboration in product template
5dc2bd8
@pedrobaeza @CarlosRoca13
[IMP] sale_elaboration: Ensure test correctness + hide is_elaboration…
0bbc01c 
… if not service
@jjscarafia @CarlosRoca13
[11.0][FIX] sale_elaboration should't be auto installed
05b4128
@marylla @CarlosRoca13
Added translation using Weblate (German)
0e7bf53
@marylla @CarlosRoca13
Translated using Weblate (German)
2d0bdbd 
Currently translated at 36.7% (11 of 30 strings)

Translation: sale-workflow-11.0/sale-workflow-11.0-sale_elaboration
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_elaboration/de/
@sergio-teruel @CarlosRoca13
[IMP] sale_elaboration: Reset "is_elaboration" in order line when use…
6588b8e 
…r changes product
@carlosdauden @CarlosRoca13
[IMP] sale_elaboration: Set is_elaboration in product tests
97f81bb
@sergio-teruel @CarlosRoca13
[FIX] sale_elaboration: Apply force_save for field is_elaboration in …
168f12b 
…sale order view to store the value in onchange method
@OCA-git-bot @CarlosRoca13
[MIG] sale_elaboration: Migration to v12.0
67366af
@sergio-teruel @CarlosRoca13
[MIG] sale_elaboration: Migration to v12.0
e992691
@sergio-teruel @CarlosRoca13
[IMP] sale_elaboration: black, isort
4be1e67
@sergio-teruel @CarlosRoca13
[MIG] sale_elaboration: Migration to v13.0
747fccb
@CarlosRoca13
[IMP] sale_elaboration: Add menu entry to sale elaboration report at …
93762d5 
…inventory reporting
@CarlosRoca13
[IMP] sale_elaboration: black, isort, prettier
c665eb8
@CarlosRoca13
Copy link
Contributor Author

This PR superseds this other: #1341

@CarlosRoca13 CarlosRoca13 mentioned this pull request Sep 28, 2022
Merged
@rousseldenis rousseldenis mentioned this pull request Sep 29, 2022
Closed
@rousseldenis
Copy link
Contributor

/ocabot migration sale_elaboration

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Sep 29, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 29, 2022
Open
88 tasks
@OCA-git-bot
Copy link
Contributor

The migration issue (#1274) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1341.
Perhaps you should check that there is no duplicate work.
CC : @JSeguiN97

rousseldenis
rousseldenis reviewed Sep 29, 2022
View reviewed changes
sale_elaboration/models/sale_order.py
from odoo import api, fields, models


def _execute_onchanges(records, field_name):
Copy link
Contributor

@rousseldenis rousseldenis Sep 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you don't like onchange_helper, but you could avoid code duplicates like this...

I encourage you to reconsider

@CarlosRoca13
Copy link
Contributor Author

Added comment and added changes suggested by @victoralmau in other PR. We prefer to keep mantaing _execute_onchanges method @rousseldenis

victoralmau
victoralmau approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK.

carlosdauden
carlosdauden approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@carlosdauden carlosdauden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking suggestion

sale_elaboration/models/product_elaboration.py Outdated
"""Give preference to codes on name search, appending
the rest of the results after.
"""
args = args if args else []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is modified, this is simpler:

Suggested change
args = args if args else []
args = args or []

@CarlosRoca13
Copy link
Contributor Author

Changed @carlosdauden 😃

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-2203-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ade420c into OCA:14.0 Sep 30, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 740eab5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@pedrobaeza pedrobaeza pedrobaeza left review comments

@carlosdauden carlosdauden carlosdauden approved these changes

@victoralmau victoralmau victoralmau approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
9 participants
@CarlosRoca13 @rousseldenis @OCA-git-bot @pedrobaeza @victoralmau @carlosdauden @sergio-teruel @jjscarafia @marylla