[14.0][MIG] sale_order_type: Migration to 14.0 #1506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIX case of tests DEL refund journal field on sale order type, now same invoice journal should be used for refunds FIX case of test FIX sale order test
Conflicts: sale_order_type/models/sale_order.py sale_order_type/models/stock_picking.py sale_order_type/tests/test_sale_order_type.py ADD Payment Term, Pricelist and Incoterm to sale order type Conflicts: sale_order_type/models/sale_order.py sale_order_type/tests/test_sale_order_type.py sale_order_type/views/sale_order_type_view.xml ADD sale type for invoices Conflicts: sale_order_type/README.rst sale_order_type/models/account_invoice.py sale_order_type/tests/test_sale_order_type.py IMP description
ADD multicompany rule for sale.order.type and company in sale.order.type (OCA#292) [IMP] sale_order_type: multicompany handle Conflicts: sale_order_type/models/sale_order_type.py
[UPD] Update sale_order_type.pot
The other one is a fake one that is dangling
…ide unnecessary features
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_type Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_type/
Currently translated at 100.0% (32 of 32 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_type Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_type/es/
As the field is set as required on the Form view, any other module that does not depend on sale_order_type and that uses test class Form on sale.order would fail with "type_id is a required field" if no default value is defined.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_type Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_type/
Actualy the field type is showed in all of the invoice types (customer and vendors), but the for the vendors invoices, it's not necesary to show it . Also the same apply for the compute method for that field.
ferran-S73
force-pushed
the
14.0-MIG-sale_order_type
branch
from
abfd798
to
a30c1ef
Compare
|
@ferran-73 Could you check travis ? |
| @@ -0,0 +1,10 @@ | |||
| [run] | |||
There was a problem hiding this comment.
Why are you modifying this ???
|
@ferran-73 It seems that you didn't look into #1274 That module is already done there. Could you review it ? |
ferran-S73
force-pushed
the
14.0-MIG-sale_order_type
branch
from
a30c1ef
to
16b4e23
Compare
You're right, didn't find it. I'll close this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration to version 14.0