-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] purchase_order_line_sequence: Migration to 16.0 #1961
base: 16.0
Are you sure you want to change the base?
[16.0][MIG] purchase_order_line_sequence: Migration to 16.0 #1961
Conversation
@AungKoKoLin1997
|
#1933 got merged, can you ensure that you have the lastest version included here? |
d5c809e
to
b83339b
Compare
b83339b
to
e258384
Compare
e258384
to
52cab2c
Compare
52cab2c
to
4cb5f87
Compare
4cb5f87
to
8c170a3
Compare
Hi guys, is there a problem with this PR? I see it's been almost a year and it's not merged. |
8c170a3
to
2a64bce
Compare
Looks like we need #1990 in here as well. |
4dbde55
to
cb5c4b7
Compare
I added the new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
FYI I based my v17 migration on this PR. #2414 |
If the creation of purchase order lines is made with form view rather than tree view then the module misbehaves, ie, creates a line with sequence 9999. This fixes that without breaking the tree view usage. It also makes sure that the sequence is kept when duplicating a purchase order, which makes more sense. It seems that this was a typo/bug on the original module which was not manifestating when using tree view but becomes clear when allowing editing of the purchase order line with form view.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/
…e if not updatable move.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/
Currently translated at 88.9% (8 of 9 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/fr/
After odoo/odoo@49b143e the sequence is correctly transmitted from purchase line to invoice line.
Currently translated at 100.0% (11 of 11 strings) Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_order_line_sequence/es/
…n section or notes in purchase order
…lds for orders and invoices
cb5c4b7
to
6a6ef4f
Compare
@oca/purchase-workflow-maintainers |
@FreezeS Can you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
Standard migration base on #1933
Depends on: OCA/stock-logistics-workflow#1316
@qrtl