Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] purchase_order_line_sequence: Migration to 16.0 #1961

Open
wants to merge 34 commits into
base: 16.0
Choose a base branch
from

Conversation

AungKoKoLin1997
Copy link
Contributor

Standard migration base on #1933
Depends on: OCA/stock-logistics-workflow#1316

@qrtl

@gbrito
Copy link

gbrito commented Aug 4, 2023

@AungKoKoLin1997
You can fix tests here by including a pending PR by adding a separated commit w/ this change in tests-requirements.txt:

odoo-addon-stock_picking_line_sequence @ git+https://github.com/OCA/stock-logistics-workflow@refs/pull/1316/head#subdirectory=setup/stock_picking_line_sequence

@LoisRForgeFlow
Copy link
Contributor

#1933 got merged, can you ensure that you have the lastest version included here?

@AungKoKoLin1997
Copy link
Contributor Author

#1933 got merged, can you ensure that you have the lastest version included here?

This PR is included the latest version of #1933

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from d5c809e to b83339b Compare October 13, 2023 07:38
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from b83339b to e258384 Compare December 1, 2023 07:16
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from e258384 to 52cab2c Compare January 25, 2024 07:26
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from 52cab2c to 4cb5f87 Compare April 18, 2024 02:41
@AungKoKoLin1997 AungKoKoLin1997 mentioned this pull request Apr 18, 2024
52 tasks
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from 4cb5f87 to 8c170a3 Compare June 10, 2024 09:52
@FreezeS
Copy link

FreezeS commented Jul 8, 2024

Hi guys, is there a problem with this PR? I see it's been almost a year and it's not merged.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from 8c170a3 to 2a64bce Compare July 31, 2024 16:01
@StefanRijnhart
Copy link
Member

Looks like we need #1990 in here as well.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from 4dbde55 to cb5c4b7 Compare September 23, 2024 14:37
@AungKoKoLin1997
Copy link
Contributor Author

Looks like we need #1990 in here as well.

I added the new commit.

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@StefanRijnhart
Copy link
Member

StefanRijnhart commented Sep 23, 2024

FYI I based my v17 migration on this PR. #2414

SerpentCS and others added 13 commits November 15, 2024 09:25
If the creation of purchase order lines is made with form view rather than tree view then the module misbehaves, ie, creates a line with sequence 9999. This fixes that without breaking the tree view usage. It also makes sure that the sequence is kept when duplicating a purchase order, which makes more sense. It seems that this was a typo/bug on the original module which was not manifestating when using tree view but becomes clear when allowing editing of the purchase order line with form view.
OCA-git-bot and others added 21 commits November 15, 2024 09:25
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/
Currently translated at 88.9% (8 of 9 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/fr/
After odoo/odoo@49b143e

the sequence is correctly transmitted from purchase line to invoice line.
Currently translated at 100.0% (11 of 11 strings)

Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_order_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_order_line_sequence/es/
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from cb5c4b7 to 6a6ef4f Compare November 15, 2024 09:25
@AungKoKoLin1997
Copy link
Contributor Author

@oca/purchase-workflow-maintainers
Can you please view this PR?

@AungKoKoLin1997
Copy link
Contributor Author

@FreezeS Can you please review?

Copy link

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.