Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Set OCA_ENABLE_CHECKLOG_ODOO by default starting with Odoo 18.0 #271

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

PabloEForgeFlow
Copy link
Contributor

No description provided.

@PabloEForgeFlow
Copy link
Contributor Author

@sbidoul I added a question for the setting, it does seem more appropriate.

Regarding version 18.0, now that both the odoo and ocb branches are up, is there something keeping us from adding support here in the template, besides the oca-ci images not existing yet? Let me know if I can help somehow.

copier.yml Outdated Show resolved Hide resolved
@sbidoul
Copy link
Member

sbidoul commented Sep 26, 2024

Thanks! Just a minor remark.

Regarding version 18.0, now that both the odoo and ocb branches are up, is there something keeping us from adding support here in the template, besides the oca-ci images not existing yet? Let me know if I can help somehow.

We can move forward with that yes. The part that requires most effort is modernizing the linter versions and configs, including pylint-odoo and friends.

@sbidoul sbidoul merged commit addc54b into OCA:master Sep 30, 2024
8 checks passed
@sbidoul
Copy link
Member

sbidoul commented Sep 30, 2024

@PabloEForgeFlow this does not always work, because the you added the new env variable in an already conditional section. See https://github.com/OCA/server-env/blob/18.0/.github/workflows/test.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants