[17.0][MIG] l10n_fr_siret_lookup #542
Conversation
Rename wizard obj to fr.siret.lookup Test on stdnum version number
Currently translated at 97.7% (43 of 44 strings) Translation: l10n-france-14.0/l10n-france-14.0-l10n_fr_siret_lookup Translate-URL: https://translation.odoo-community.org/projects/l10n-france-14-0/l10n-france-14-0-l10n_fr_siret_lookup/fr/
'codedepartementetablissement' is not always set (in particular for companies in Corsica), so we now only use codepostaletablissement
Currently translated at 100.0% (44 of 44 strings) Translation: l10n-france-14.0/l10n-france-14.0-l10n_fr_siret_lookup Translate-URL: https://translation.odoo-community.org/projects/l10n-france-14-0/l10n-france-14-0-l10n_fr_siret_lookup/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-france-16.0/l10n-france-16.0-l10n_fr_siret_lookup Translate-URL: https://translation.odoo-community.org/projects/l10n-france-16-0/l10n-france-16-0-l10n_fr_siret_lookup/
Currently translated at 100.0% (44 of 44 strings) Translation: l10n-france-16.0/l10n-france-16.0-l10n_fr_siret_lookup Translate-URL: https://translation.odoo-community.org/projects/l10n-france-16-0/l10n-france-16-0-l10n_fr_siret_lookup/es/
There was a problem hiding this comment.
Hi @David-Luis-Mora, thank you for porting this module.
Could you please explain why you moved the readonly attributes on wizard from Python code to XML view ?
Thanks
Found it in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#tasks-to-do-in-the-migration (related to import module functionality) ! |
There was a problem hiding this comment.
Thanks @David-Luis-Mora for porting this module.
Some minor comment related to XML tag not necessary anymore in index.html raising a WARNING during installation.
Apart from this, 👍
| @@ -0,0 +1,477 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
| <?xml version="1.0" encoding="utf-8"?> |
This line should be removed otherwise you get a warning error when installing the module :
WARNING odoo17 py.warnings: /home/user/dev/odoo17/ocb/odoo/addons/base/models/ir_module.py:178: DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17, l10n_fr_siret_lookup can just have a UTF8 description with not need for a declaration.
Note : this was fixed in maintainer-tools with OCA/maintainer-tools#596 back in December 23 so it should not be present anymore when pre-commit reissues the index.html
There was a problem hiding this comment.
@David-Luis-Mora please can you make this correction so that the module in version 17.0 is available to the community?
|
Hi @David-Luis-Mora , any chance to rebase for the CI |
|
/ocabot migration l10n_fr_siret_lookup |
No description provided.