[14.0][IMP] l10n_br_fiscal: tax_definition add Service Type #3471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mileo
approved these changes
Oct 28, 2024
kaynnan
changed the title
kaynnan
force-pushed
the
14.0-imp-l10n_br_fiscal-ht00887
branch
from
1167db2
to
0469c56
Compare
|
Rebase realizado para constar o runboat, ele não estava disponível para os testes |
kaynnan
force-pushed
the
14.0-imp-l10n_br_fiscal-ht00887
branch
from
0469c56
to
ec1f5d0
Compare
marcelsavegnago
approved these changes
Oct 30, 2024
douglascstd
suggested changes
Oct 30, 2024
There was a problem hiding this comment.
[FUNCIONAL REVIEW] [CHANGE REQUEST]
Teste realizado:
Ponto de melhoria:
- Ao alterar o campo Tipo LC ("Service Type LC 166") não tem o recalculo, e fazia sentido antes desta PR, pois essa informação não entrava na composição. Agora faz sentido esse campo acionar o calculo de impostos
https://github.com/user-attachments/assets/0640fe17-c727-4e92-8e48-74b82f06a121
rvalyi
approved these changes
Oct 30, 2024
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 43390f7. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[HT00887]
cc @marcelsavegnago @WesleyOliveira98 @douglascstd