[15.0][FIX][l10n_br_account] reordering vals_list to correctly associate with with fiscal_document_line - port de #3077 #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create should return the records in the initial order of the vals_list to avoid side effects.
|
Hi @renatonlima, |
marcelsavegnago
approved these changes
May 16, 2024
marcelsavegnago
requested review from
antoniospneto,
mileo,
felipemotter and
kaynnan
mileo
approved these changes
May 17, 2024
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at cc15c05. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port de #3077; bem urgente pois temos a mesma regressão de #3064 na 15.0 depois que houve o port em #3069
pessoal eu não entendi porque os commits com fixup não tiveram squash na hora de merge de #3077 (alguem entendeu?), mas enfim nisso re-fiz os mesmos 4 commits do que na 14.0 exactamente (com cherry-pick).
cc @dreispt @mileo se vcs mexem na v15, esse PR é importante!