[16.0] [MIG] helpdesk_mgmt_fieldservice: Migration to 16.0 #608

anusriNPS · 2024-07-22T08:35:58Z

MIgrating helpdesk_mgmt_fieldservice to 16.0 version

When trying to open a res_partner form with a user who doesn't have permission for read fieldservice data, this view causes an error cause it try to set attributes to a button that doesn't exist. Specifying groups_id fix this, extending the view only if the current user has permissions to see that button.

Currently translated at 100.0% (32 of 32 strings) Translation: helpdesk-12.0/helpdesk-12.0-helpdesk_mgmt_fieldservice Translate-URL: https://translation.odoo-community.org/projects/helpdesk-12-0/helpdesk-12-0-helpdesk_mgmt_fieldservice/fr/

Currently translated at 100.0% (36 of 36 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_fieldservice Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_fieldservice/it/

Currently translated at 100.0% (36 of 36 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_fieldservice Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_fieldservice/es/

Currently translated at 100.0% (36 of 36 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_fieldservice Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_fieldservice/pt_BR/

renda-dev · 2024-07-29T07:32:23Z

helpdesk_mgmt_fieldservice/views/res_partner.xml

            <button name="action_view_helpdesk_tickets" position="attributes">
                <attribute
                    name="context"
-                >{'default_partner_id': id, 'default_fsm_location_id': service_location_id}</attribute>
+                    groups="fieldservice.group_fsm_user_own"
+                >{'default_partner_id': id}</attribute>
            </button>


question: these changes are not really clear to me, could you give me some context and explain these?

With migration 16.0 page, this point was mentioned:
I am not able to use groups_id in views instead need to add groups attribute in the field itself. Hence this change was introduced

Any view with groups_id on it now has to move such groups to the elements of the view. But now you can put groups attribute in a view field instead of isolating it on a view without fear of an access error. Check it in odoo/odoo#98551.

Okay, looks great! But why the default location has been removed?

Sorry for delayed response. I shouldn't have removed service_location_id while incorporating "groups" for the button. Hope the latest code looks fine

Perfect, thanks!

renda-dev · 2024-07-30T13:00:57Z

helpdesk_mgmt_fieldservice/views/res_partner.xml

+    <record id="res_partner_form_ticket_context" model="ir.ui.view">
+        <field name="name">res.partner.form.ticket.context</field>
+        <field name="model">res.partner</field>
+        <field name="inherit_id" ref="base.view_partner_form" />
+        <field name="arch" type="xml">
+            <field name="service_location_id" invisible="1" />
+            <button name="action_view_helpdesk_tickets" position="attributes">
+                <attribute name="groups">fieldservice.group_fsm_user_own</attribute>
+                <attribute
+                    name="context"
+                >{'default_partner_id': id, 'default_fsm_location_id': service_location_id}</attribute>
+            </button>
+        </field>
+    </record>


issue: it seems that in 14.0, this customization was made available only for users with the group fieldservice.group_fsm_user_own, while now you are making the whole button available only for the users with that group.

Could you please check and fix the issue to make the functionality the same as it was before?

Removed groups_id and for accessing service_location_id field which can be accessed only with groups "fieldservice.group_fsm_user_own" is added in the parent view with invisible attribute so that functionality would remain the same.

Could you please double check? I feel like that to preserve the full functionality you should:

Use two buttons, the one already existing and create a new one

The first should be visible if you have the group, the other one not

The one visible if you have the group should also have the customization made in this inheritance

Let me know if everything is clear :)

This seems solved.

anusriNPS · 2024-09-10T08:33:17Z

As per latest changes, when user is provided with group for helpdesk and not for fieldservice, below view is observed:

Provided user permission:

aleuffre

Minor comment to fix a bug that was already present in previous versions

But in general, LGTM (Code review)

aleuffre · 2024-09-17T08:28:46Z

helpdesk_mgmt_fieldservice/views/res_partner.xml

        <field name="inherit_id" ref="base.view_partner_form" />
        <field name="arch" type="xml">
-            <button name="action_view_helpdesk_tickets" position="attributes">
+              <button name="action_view_helpdesk_tickets" position="before">
+                 <field name="service_location_id" invisible="1" />
+              </button>
+              <button name="action_view_helpdesk_tickets" position="attributes">


chore: an issue that we should fix is that the <button name="action_view_helpdesk_tickets"> is not present in base.view_partner_form but is added by helpdesk_mgmt.view_partner_form so we should inherit from that view

Yes, this has to be inherited from helpdesk_mgmt.view_partner_form which is the right way to inherit as mentioned by you.

However, I see issue still persists with updating button with group attribute to "fieldservice.group_fsm_user_own" and having helpdesk_mgmt and fieldservice modules installed along with helpdesk_mgmt_fieldservice with user provided only with helpdesk_mgmt but not with fieldservice, helpdesk button is not visible in the contacts view as shown below:

Please let me know your views on it.

aleuffre · 2024-09-17T08:30:22Z

helpdesk_mgmt_fieldservice/views/res_partner.xml

+    <record id="res_partner_form_ticket_context" model="ir.ui.view">
+        <field name="name">res.partner.form.ticket.context</field>
+        <field name="model">res.partner</field>
+        <field name="inherit_id" ref="base.view_partner_form" />
+        <field name="arch" type="xml">
+            <field name="service_location_id" invisible="1" />
+            <button name="action_view_helpdesk_tickets" position="attributes">
+                <attribute name="groups">fieldservice.group_fsm_user_own</attribute>
+                <attribute
+                    name="context"
+                >{'default_partner_id': id, 'default_fsm_location_id': service_location_id}</attribute>
+            </button>
+        </field>
+    </record>


This seems solved.

anusriNPS · 2024-09-25T15:54:49Z

action_view_helpdesk_ticket function is overridden by replacing context when both groups "helpdesk_mgmt.group_helpdesk_user_own" and "fieldservice.group_fsm_user_own" are available

Functionality for button in 14 and 16 versions:

Odoo 14:

Helpdesk - Manager, Fieldservice - Manager - Has context with default_location_id, default_partner_id
Helpdesk - User, Fieldservice - Disable - Button is visible but context has search_default_open, default_partner_id
Helpdesk - disable, Fieldservice - User only - Button not visible context could not be checked

Odoo 16:

Helpdesk - Manager, Fieldservice - Manager - context contains default_location_id, default_partner_id
Helpdesk - User, Fieldservice - Disable - Button is visible but context has only search_default_open, default_partner_id
Helpdesk - disable, Fieldservice - User only - Button not visible context could not be checked

aleuffre

Code review, LGTM

PicchiSeba

Code review: LGTM

anusriNPS marked this pull request as draft July 22, 2024 08:36

marcelsavegnago and others added 16 commits July 22, 2024 10:46

[ADD] helpdesk_mgmt_fieldservice integration

f80aeb1

Added translation using Weblate (Catalan)

d78f830

Added translation using Weblate (French)

32fa89a

fixed xml id in fsm_location.py

1d77e9b

Added translation using Weblate (Spanish)

b944b3b

Translated using Weblate (French)

433a3e6

Currently translated at 100.0% (32 of 32 strings) Translation: helpdesk-12.0/helpdesk-12.0-helpdesk_mgmt_fieldservice Translate-URL: https://translation.odoo-community.org/projects/helpdesk-12-0/helpdesk-12-0-helpdesk_mgmt_fieldservice/fr/

[IMP] helpdesk_mgmt_fieldservice: black, isort, prettier

d367471

[DCK] helpdesk_mgmt_fieldservice: Change the license from LGPL to AGPL.

c08e158

Added translation using Weblate (Spanish (Argentina))

33e5e03

Added translation using Weblate (Italian)

2200184

*: pylint fixes

0374dc9

Translated using Weblate (Italian)

8f8237d

Currently translated at 100.0% (36 of 36 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_fieldservice Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_fieldservice/it/

Translated using Weblate (Spanish)

a526776

Currently translated at 100.0% (36 of 36 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_fieldservice Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_fieldservice/es/

[IMP] helpdesk_mgmt_fieldservice: pre-commit execution

34c9ae2

anusriNPS force-pushed the 16.0-mig-helpdesk_mgmt_fieldservice branch 5 times, most recently from d0687ba to c8a33eb Compare July 23, 2024 09:55

anusriNPS marked this pull request as ready for review July 23, 2024 10:03

renda-dev reviewed Jul 29, 2024

View reviewed changes

anusriNPS force-pushed the 16.0-mig-helpdesk_mgmt_fieldservice branch from c8a33eb to 99e9757 Compare July 30, 2024 09:55

renda-dev reviewed Jul 30, 2024

View reviewed changes

anusriNPS force-pushed the 16.0-mig-helpdesk_mgmt_fieldservice branch from 99e9757 to 6b0d16d Compare August 12, 2024 13:42

anusriNPS force-pushed the 16.0-mig-helpdesk_mgmt_fieldservice branch 2 times, most recently from 186f5dc to 39e4ab9 Compare August 28, 2024 06:02

anusriNPS force-pushed the 16.0-mig-helpdesk_mgmt_fieldservice branch from 39e4ab9 to 8eb0982 Compare September 10, 2024 08:30

aleuffre approved these changes Sep 17, 2024

View reviewed changes

anusriNPS force-pushed the 16.0-mig-helpdesk_mgmt_fieldservice branch 3 times, most recently from 1c883c1 to deb1d7b Compare September 17, 2024 11:06

anusriNPS force-pushed the 16.0-mig-helpdesk_mgmt_fieldservice branch 2 times, most recently from 8a63a0f to deb512d Compare September 25, 2024 15:50

[MIG] helpdesk_mgmt_fieldservice: Migration to 16.0

19100f3

anusriNPS force-pushed the 16.0-mig-helpdesk_mgmt_fieldservice branch from deb512d to 19100f3 Compare September 25, 2024 15:56

aleuffre approved these changes Sep 27, 2024

View reviewed changes

PicchiSeba approved these changes Oct 14, 2024

View reviewed changes

OCA-git-bot added the approved label Oct 14, 2024

imlopes approved these changes Nov 5, 2024

View reviewed changes

imlopes mentioned this pull request Nov 5, 2024

[17.0][MIG] helpdesk_mgmt_fieldservice #652

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0] [MIG] helpdesk_mgmt_fieldservice: Migration to 16.0 #608

[16.0] [MIG] helpdesk_mgmt_fieldservice: Migration to 16.0 #608

anusriNPS commented Jul 22, 2024

renda-dev Jul 29, 2024

anusriNPS Jul 29, 2024

renda-dev Jul 29, 2024

anusriNPS Jul 30, 2024

renda-dev Jul 30, 2024

renda-dev Jul 30, 2024

anusriNPS Aug 12, 2024 •

edited

Loading

renda-dev Aug 19, 2024

aleuffre Sep 17, 2024

anusriNPS commented Sep 10, 2024

aleuffre left a comment

aleuffre Sep 17, 2024

anusriNPS Sep 17, 2024

aleuffre Sep 17, 2024

anusriNPS commented Sep 25, 2024

aleuffre left a comment

PicchiSeba left a comment

[16.0] [MIG] helpdesk_mgmt_fieldservice: Migration to 16.0 #608

Are you sure you want to change the base?

[16.0] [MIG] helpdesk_mgmt_fieldservice: Migration to 16.0 #608

Conversation

anusriNPS commented Jul 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anusriNPS Aug 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anusriNPS commented Sep 10, 2024

aleuffre left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anusriNPS commented Sep 25, 2024

Odoo 14:

Odoo 16:

aleuffre left a comment

Choose a reason for hiding this comment

PicchiSeba left a comment

Choose a reason for hiding this comment

anusriNPS Aug 12, 2024 •

edited

Loading