Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] delivery_postlogistics: raise exception when no token received #898

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[FIX] delivery_postlogistics: raise exception when no token received #898

merged 1 commit into from
Nov 11, 2024

Conversation

ajaniszewska-dev
Copy link
Contributor

Sometimes due to API error it may happen we don't receive anything back when requesting token. In this case we want to show meaningful message.

twalter-c2c
twalter-c2c approved these changes Oct 30, 2024
View reviewed changes
Copy link

@twalter-c2c twalter-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajaniszewska-dev ajaniszewska-dev force-pushed the postlog_token_err_impr branch 12 times, most recently from 73da793 to 758a53a Compare October 31, 2024 08:59
@ajaniszewska-dev
Copy link
Contributor Author

do not merge ATM, seems this exception is not correctly raised (raised when service works fine)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ajaniszewska-dev ajaniszewska-dev force-pushed the postlog_token_err_impr branch 4 times, most recently from 018becf to 867d06d Compare November 5, 2024 10:03
@ajaniszewska-dev ajaniszewska-dev mentioned this pull request Nov 5, 2024
Closed
simahawk
simahawk requested changes Nov 11, 2024
View reviewed changes
delivery_postlogistics/tests/test_postlogistics.py Outdated

def test_postlogistics_get_token_error(self):
with recorder.use_cassette("test_token_error") as cassette:
with self.assertRaises(UserError):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always better to use assertRaisesRegex w/ a pattern matching the error msg.
Too often I've seen an exception raised somewhere else 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @simahawk , updated test.

@ajaniszewska-dev
[FIX] delivery_postlogistics: raise exception when no token received
0b14913 
Sometimes due to API error it may happen we don't receive anything back when requesting token.
In this case we want to show meaningful message.
@simahawk
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-898-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8e93836 into OCA:16.0 Nov 11, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1c61d7b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grindtildeath grindtildeath grindtildeath approved these changes

@twalter-c2c twalter-c2c twalter-c2c approved these changes

@henrybackman henrybackman henrybackman approved these changes

@mmequignon mmequignon mmequignon approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ajaniszewska-dev @OCA-git-bot @simahawk @grindtildeath @mmequignon @henrybackman @twalter-c2c