[14.0][ADD] delivery_purchase_label #863
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaudoux
reviewed
Jul 24, 2024
vuwnevska
reviewed
Jul 25, 2024
ivantodorovich
approved these changes
Jul 29, 2024
jbaudoux
reviewed
Aug 21, 2024
mt-software-de
suggested changes
Sep 10, 2024
mt-software-de
suggested changes
Sep 17, 2024
mt-software-de
suggested changes
Sep 20, 2024
Comment on lines
86
to
126
| order = self.with_company(self.company_id) | ||
| # Create and process the transer to send the labels | ||
| values = order._get_purchase_delivery_label_picking_value(carrier) | ||
| picking = self.env["stock.picking"].with_user(SUPERUSER_ID).create(values) | ||
| moves = order.order_line._create_stock_moves(picking) | ||
| moves.location_id = picking.location_id | ||
| moves.location_dest_id = picking.location_dest_id | ||
| # Remove the link on the sale and purchase | ||
| # To not impact the delivered quantity on them | ||
| picking.sale_id = False | ||
| moves.sale_line_id = False | ||
| moves.purchase_line_id = False | ||
| picking.action_assign() | ||
| # Moves can change on action assign | ||
| moves = picking.move_lines | ||
| for move in moves: | ||
| move.quantity_done = move.product_uom_qty |
There was a problem hiding this comment.
Could this please move into an own method.
Including also line 113 picking._action_done
jbaudoux
requested changes
Sep 20, 2024
| if not self._is_valid_for_vendor_labels(): | ||
| return | ||
| # Find the carrier that will be used | ||
| carrier = self.partner_id.purchase_delivery_carrier_id |
There was a problem hiding this comment.
We need a carrier on the PO as initially stated. Use cases showed that the vendor will not always ship with the same carrier. You can keep partner purchase_delivery_carrier_id as a fallback value but ideally we shouldn't configure any partner. We are generating drop-shipping PO and the PO carrier should come from the SO delivery carrier.
I would define a field on the PO like vendor_label_carrier_id.
This new field should be filled in when the PO is created/updated (done outside this module).
Suggested change
| carrier = self.partner_id.purchase_delivery_carrier_id | |
| carrier = self.vendor_label_carrier_id or self.partner_id.purchase_delivery_carrier_id |
jbaudoux
reviewed
Sep 24, 2024
mt-software-de
approved these changes
Oct 29, 2024
jbaudoux
approved these changes
Oct 31, 2024
Print delivery labels for dropshipping purchase order. Useful when then vendor that will process the order does not have the capabilities to print the transporter labels needed for the delivery.
…ransfer to purchase order
Limit the generation of new transfer for delivery label by using a savepoint, if no there is no changes the transfer will not be kept
TDu
force-pushed
the
14-add-delivery-purchase-label
branch
from
ea36065
to
8ca839b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print delivery labels for dropshipping purchase order. Useful when then vendor that will process the order does not have the capabilities to print the transporter labels needed for the delivery.