[16.0][FIX] account_payment_sale: Force add payment mode in invoice vals

[ramiadavid]

Since this PR #1246 was added, an error occurs when there are orders without payment_mode_id along with others that do have them when comparing None > int
`TypeError: '<' not supported between instances of 'NoneType' and 'int'

The error occurs here:
https://github.com/odoo/odoo/blob/fe2fb05892e273587996a2f68cd53fc4f8604c6e/addons/sale/models/sale_order.py#L1149-L1156

Fixed by forcing payment_mode_id to be added even if it is empty because False can be compared with integer

[francesco-ooops]

@rousseldenis can you confirm the issue?

[ramiadavid]

@francesco-ooops I have added a test to see the error

[ramiadavid]

Pre-commit fails due to another module: account_banking_pain_base

[PicchiSeba]

@ramiadavid Can you rebase? This might fix the pre-commit error

[PicchiSeba]

Code Review: LGTM

[pedrobaeza]

Although I agree there should be a solution, the intention of no setting such vals is to keep the partner's payment mode in the moment of the invoice creation, so what about assigning such payment mode following the same rules as if you select the partner in the invoice?

[rousseldenis]

@rousseldenis can you confirm the issue?

I'll check but indeed this seems correct.

[pedrobaeza]

Please check my comment

[rousseldenis]

Although I agree there should be a solution, the intention of no setting such vals is to keep the partner's payment mode in the moment of the invoice creation, so what about assigning such payment mode following the same rules as if you select the partner in the invoice?

Because payment mode could be set manually on the order side and should be kept. If I have understood your question

[pedrobaeza]

It's not a direct question, but how to implement the fix.

[pedrobaeza]

I clarify more: I'm asking for not putting vals["payment_mode_id"] = False, but in case of not having any payment mode in the sales order, to assign the payment mode following this logic:

bank-payment/account_payment_partner/models/account_move.py

Line 62 in 2f446b3

def _compute_payment_mode_id(self):

which is what happens currently.

[pedrobaeza]

The other option is to strip out the vals entry before creation if False for letting the computed to act.

This can be more optimal for avoiding to duplicate code.

[rousseldenis]

I clarify more: I'm asking for not putting vals["payment_mode_id"] = False, but in case of not having any payment mode in the sales order, to assign the payment mode following this logic:

bank-payment/account_payment_partner/models/account_move.py

Line 62 in 2f446b3

def _compute_payment_mode_id(self):

which is what happens currently.

Yes, I've just seen it.

@ramiadavid Could you maybe try to remove the get_payment_mode_vals() function and override the compute methods defined in account_payment_partner instead ?

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.