Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] account_global_discount: 16.0 #1338

Closed
wants to merge 49 commits into from

Commits on Mar 15, 2024

  1. Configuration menu
    Copy the full SHA
    d7df8b8 View commit details
    Browse the repository at this point in the history
  2. [FIX+IMP] account_global_discount: link line taxes to discount move l…

    …ine + Discounts in invoice report
    
    [IMP] account_global_discount: Discounts in invoice report
    
    Give discounts info in the invoice report.
    
    [FIX] account_global_discount: link line taxes to discount move line
    chienandalu authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    c76d10b View commit details
    Browse the repository at this point in the history
  3. [FIX] account_global_discount: More on global discount/taxes link

    - We need to take into account invoice lines with multiple taxes, so the link should
      be m2m.
    - Migration scripts for preserving the best information on existing installations.
    - Tests for checking new conditions.
    - Perform sanity check for not ending in an incompatible situation.
    - Some refactor done on onchanges for avoiding duplicating operations.
    - Adjust UI for not allowing to edit computed invoice global discounts.
    pedrobaeza authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    7a28775 View commit details
    Browse the repository at this point in the history
  4. [MIG] acount_global_discount: Migration to 12.0

    - Standard procedure
    - Make test more resilient
    pedrobaeza authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b4a2bb5 View commit details
    Browse the repository at this point in the history
  5. [IMP] account_global_discount: Deprecated use of currency compute

    Replaced by more explicit `_convert` method.
    pedrobaeza authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    dce55dd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c583f0a View commit details
    Browse the repository at this point in the history
  7. [FIX] account_global_discount: Fix singleton error in _compute_amount

    For reducing diff, we rename the method and call it record per record.
    
    Fixes OCA#788
    pedrobaeza authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ddf6c18 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7e0aa33 View commit details
    Browse the repository at this point in the history
  9. [IMP] account_global_discount: black, isort, prettier

    Ernesto Tejeda authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    73cba28 View commit details
    Browse the repository at this point in the history
  10. [MIG] account_global_discount: Migration to 13.0

    [UPD] Update account_global_discount.pot
    
    Update translation files
    
    Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.
    
    Translation: account-invoicing-13.0/account-invoicing-13.0-account_global_discount
    Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_global_discount/
    Ernesto Tejeda authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    74508fc View commit details
    Browse the repository at this point in the history
  11. [FIX] account_global_discount: wrong tax move line discounts on invoi…

    …ce post
    Ernesto Tejeda authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    429c7e5 View commit details
    Browse the repository at this point in the history
  12. account_global_discount 13.0.1.0.1

    OCA-git-bot authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2c6a478 View commit details
    Browse the repository at this point in the history
  13. [FIX] account_global_discount: Compute global discount with 0% taxes

    Co-Authored-By: Pedro M. Baeza <[email protected]>
    
    [UPD] README.rst
    victoralmau authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4ef4452 View commit details
    Browse the repository at this point in the history
  14. Added translation using Weblate (Dutch)

    Cas Vissers authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    fc7847f View commit details
    Browse the repository at this point in the history
  15. Translated using Weblate (Dutch)

    Currently translated at 100.0% (35 of 35 strings)
    
    Translation: account-invoicing-13.0/account-invoicing-13.0-account_global_discount
    Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_global_discount/nl_NL/
    
    [UPD] Update account_global_discount.pot
    Cas Vissers authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    6a3e7b8 View commit details
    Browse the repository at this point in the history
  16. Update translation files

    Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.
    
    Translation: account-invoicing-13.0/account-invoicing-13.0-account_global_discount
    Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_global_discount/
    oca-transbot authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    85591c0 View commit details
    Browse the repository at this point in the history
  17. Translated using Weblate (Spanish)

    Currently translated at 100.0% (34 of 34 strings)
    
    Translation: account-invoicing-13.0/account-invoicing-13.0-account_global_discount
    Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_global_discount/es/
    anasuarez1 authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2404016 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    e2a81bd View commit details
    Browse the repository at this point in the history
  19. account_global_discount 13.0.1.0.2

    OCA-git-bot authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    7706430 View commit details
    Browse the repository at this point in the history
  20. [FIX] account_global_discount: discounts on create

    When we set the global discount on the create method we must ensure that
    the move lines are properly recomputed
    chienandalu authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    565ffb8 View commit details
    Browse the repository at this point in the history
  21. [IMP] account_global_discount: security group

    Users will need a specific group to set global discounts so it's easier
    to decide who's allowed to apply them.
    
    [UPD] Update account_global_discount.pot
    chienandalu authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    1f091c7 View commit details
    Browse the repository at this point in the history
  22. account_global_discount 13.0.1.1.0

    Update translation files
    
    Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.
    
    Translation: account-invoicing-13.0/account-invoicing-13.0-account_global_discount
    Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_global_discount/
    OCA-git-bot authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    626fa86 View commit details
    Browse the repository at this point in the history
  23. [FIX] account_global_discount: Prevent error when add more taxes in m…

    …ulti-lines from invoices when global discount is empty
    victoralmau authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    3e3df3e View commit details
    Browse the repository at this point in the history
  24. account_global_discount 13.0.1.1.1

    OCA-git-bot authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    8e839e9 View commit details
    Browse the repository at this point in the history
  25. [FIX+REF] account_global_discount: Include taxes in global discount m…

    …ove lines
    
    Previously, no taxes were populated as base taxes for global discount
    move lines, which means that the tax reports were incorrect.
    
    The global discount lines + move lines has been injected other way for
    avoiding inconsistencies, and the rest of the features have been adapted
    according this.
    
    A migration script is provided as well for filling taxes in existing
    global discount move lines.
    
    [UPD] Update account_global_discount.pot
    
    [UPD] README.rst
    
    Update translation files
    
    Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.
    
    Translation: account-invoicing-13.0/account-invoicing-13.0-account_global_discount
    Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_global_discount/
    pedrobaeza authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4b13c74 View commit details
    Browse the repository at this point in the history
  26. [FIX] account_global_discount: Call the proper method on create

    For recomputing the global discounts, now we need to call another method.
    
    TT30077
    pedrobaeza authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b76951e View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    1a380b0 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    82d1ed4 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    dbafbc8 View commit details
    Browse the repository at this point in the history
  30. [FIX] account_global_discount: computed fields must be stored because…

    … the other standard computed fields in same method are
    omar7r authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    fcea1d2 View commit details
    Browse the repository at this point in the history
  31. [FIX] account_global_discount: Filtering global discount in on_change…

    … by invoice's company
    omar7r authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    0a54b98 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    a9eb236 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    718a1a6 View commit details
    Browse the repository at this point in the history
  34. [FIX] account_global_discount: When writing Odoo doesn't autocomplete…

    … amount_currency and it could fail with constraint
    omar7r authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    d3a12f0 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    d9cf683 View commit details
    Browse the repository at this point in the history
  36. [UPD] README.rst

    OCA-git-bot authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    9e1d78a View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    8fb75f2 View commit details
    Browse the repository at this point in the history
  38. Translated using Weblate (Italian)

    Currently translated at 100.0% (36 of 36 strings)
    
    Translation: account-invoicing-14.0/account-invoicing-14.0-account_global_discount
    Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_global_discount/it/
    francesco-ooops authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    61d400c View commit details
    Browse the repository at this point in the history
  39. [FIX] *: Change _recompute_tax_lines args according upstream

    odoo/odoo@c9d5f06
    has changed the number of arguments on the method `_recompute_tax_lines`,
    so we need to adapt the overrides to such change.
    pedrobaeza authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ec7da08 View commit details
    Browse the repository at this point in the history
  40. account_global_discount 14.0.1.0.1

    OCA-git-bot authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    29fa1a6 View commit details
    Browse the repository at this point in the history
  41. Translated using Weblate (Portuguese)

    Currently translated at 100.0% (35 of 35 strings)
    
    Translation: account-invoicing-14.0/account-invoicing-14.0-account_global_discount
    Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_global_discount/pt/
    pedrocs-exo authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    011401b View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    8079448 View commit details
    Browse the repository at this point in the history
  43. [FIX] account_global_discount: multi-currency

    In a foreign currency invoice the amounts (amount_total,
    amount_untaxed) are expressed in the `invoice` currency while the
    accounting entry lines are expressed in the `company` currency.
    
    The base_before_global_discounts has to be expressed in the invoice
    currency as well in such invoices because the discounts need to be
    computed in the same currency as the other amounts.
    
    Also set the invoice currency_id on the tax line so that it doesn't
    default to the company currency, and convert the discount journal entry
    amount to the company currnecy.
    kirca authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    aa774e9 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    3e157c6 View commit details
    Browse the repository at this point in the history
  45. [MIG] account_global_discount: 16.0

    ferran-S73 authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    82c6816 View commit details
    Browse the repository at this point in the history
  46. [DON'T MERGE] test-requirements.txt

    ferran-S73 authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    859d403 View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    fa2a3b0 View commit details
    Browse the repository at this point in the history
  48. [FIX] account_global_discount: Make tests resilient

    - Depending on the installed set of modules, the company currency may
      be USD or EUR. If the second case, these tests will fail, so we make
      sure that the company currency is USD for our tests, doing the change
      by SQL, as there's a Python constraint that prevents it.
    
    Not needed in v17 due to: odoo/odoo#107113.
    OCA-git-bot authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    464cb85 View commit details
    Browse the repository at this point in the history
  49. [14.0][IMP] account_global_discount, added init hook to avoid memory …

    …issues on big database installation
    ChrisOForgeFlow authored and miguel-S73 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    df03898 View commit details
    Browse the repository at this point in the history