Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_move_update_analytic #559

Merged
merged 12 commits into from
Sep 20, 2023
Merged

[16.0][MIG] account_move_update_analytic #559

merged 12 commits into from
Sep 20, 2023

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented May 24, 2023 •
edited
Loading

@hbrunn hbrunn added this to the 16.0 milestone May 24, 2023
@rafaelbn
Copy link
Member

/ocabot migration account_move_update_analytic

@OCA-git-bot OCA-git-bot mentioned this pull request May 30, 2023
Open
17 tasks
@rousseldenis
Copy link
Contributor

@hbrunn Could you squash your commits and rebase ?

remi-filament and others added 11 commits July 19, 2023 16:04
@remi-filament @hbrunn
[ADD] module account_move_update_analytic
aa89fd0
@remi-filament @hbrunn
[UPD] changes from Shide
83f97ff
@Shide @hbrunn
[MIG] account_move_update_analytic: Migration to 15.0
afe7ac5
@hbrunn
[UPD] Update account_move_update_analytic.pot
a70cc35
@OCA-git-bot @hbrunn
[UPD] README.rst
2b17e0f
@OCA-git-bot @hbrunn
account_move_update_analytic 15.0.1.0.1
5c3a125
@weblate @hbrunn
Update translation files
f21a816 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-analytic-15.0/account-analytic-15.0-account_move_update_analytic
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-15-0/account-analytic-15-0-account_move_update_analytic/
@norlinhenrik @hbrunn
[IMP] account_move_update_analytic: hide button column when not posted
60e9941
@norlinhenrik @hbrunn
[IMP] account_move_update_analytic: default new = current
326fc2c
@OCA-git-bot @hbrunn
account_move_update_analytic 15.0.1.1.0
5a71e0e
@hbrunn
[MIG] account_move_update_analytic to v16
06fa73c
@hbrunn hbrunn force-pushed the 16.0-account_move_update_analytic branch from c3f9d6d to 06fa73c Compare July 19, 2023 14:05
@hbrunn
Copy link
Member Author

hbrunn commented Jul 19, 2023

@rousseldenis thanks, done

rousseldenis
rousseldenis approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review

rafaelbn
rafaelbn reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hbrunn !

Thank you!

I miss the option in 14 and 15 for updating from the invoice, see:

imagen

In this PR is missing

imagen

@hbrunn
Copy link
Member Author

hbrunn commented Jul 27, 2023

this lives in the journal items tab, seemed more logical to me

@rafaelbn
Copy link
Member

Hello @hbrunn ,

this lives in the journal items tab, seemed more logical to me

I repect really, but we don't make software more logical for us, we make for accountants and in general users.

Users expect in the lines and not in other tab

  • more clics
  • different place to update than the place you set <- illogic

Please, keep it in the place it was 🙏🏼 it was analysed with different accountants from different clients before decisions. I mean is a conscious product decision.

Le me know 😄

Thank you!
Best regards,
Rafael

@hbrunn
Copy link
Member Author

hbrunn commented Jul 31, 2023

@rafaelbn moved it back to where it was, will then do the "more logical" part in my customer's private module ;-)

rafaelbn
rafaelbn approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hbrunn ! 👍🏼

I really will still ask for more point of view, thank you ❤️

imagen

@rafaelbn
Copy link
Member

rafaelbn commented Aug 3, 2023

/ocabot migration patch

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hbrunn
Copy link
Member Author

hbrunn commented Aug 4, 2023

/ocabot migration account_move_update_analytic

EmilioPascual
EmilioPascual approved these changes Sep 19, 2023
View reviewed changes
Copy link

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaelbn
Copy link
Member

/ocabot migration patch

@rafaelbn
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-559-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 887caf8 into OCA:16.0 Sep 20, 2023
4 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 04c38e3. Thanks a lot for contributing to OCA. ❤️

@gjlong68
Copy link

miss analytic tags
image

@rafaelbn
Copy link
Member

Hello @hbrunn !

Just to inform you, this module is not needed any more in Odoo 16 to update from move lines (journal items) because Odoo allow it in the list view with multi-edit.

Then need of this module is only if you need to update analytic from invoices exclusively. I mean a Billing user that doesn't have access to full accounting.

😄

@gjlong68 , Odoo 16 don't have un core anymore analytic tags, so a new module is needed for that depending in the OCA module which adds again the analytic tags. Not aplicable in this module.

Ping @remi-filament !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilioPascual EmilioPascual EmilioPascual approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
10 participants
@hbrunn @rafaelbn @rousseldenis @OCA-git-bot @gjlong68 @EmilioPascual @remi-filament @Shide @weblate @norlinhenrik