feat: add schema tests and official JSON Schema #94
Conversation
schemas/v1.0/schema.yaml
Outdated
| allOf: | ||
| - description: The `update` field has no impact if the `remove` field of this | ||
| action object is true. | ||
| if: | ||
| properties: | ||
| remove: | ||
| const: true | ||
| required: | ||
| - remove | ||
| then: | ||
| not: | ||
| required: | ||
| - update |
There was a problem hiding this comment.
This is stricter than the specification, which allows update together with remove: true.
I'd rather remove this, and also remove the test case fail/actions-no-update-with-remove.yaml.
There was a problem hiding this comment.
i asked for clarification on this in #71
I think allowing this in the schema introduces an ambiguous implementation detail.. does the remove apply first, or the update? Specifically because the spec indicates actions should be performed in order
There was a problem hiding this comment.
Let's wait for the outcome of #71 then with merging this PR.
There was a problem hiding this comment.
The schema validator we use thinks this allOf construct is invalid.
There was a problem hiding this comment.
when I removed the description, i missed the array syntax was removed. That's why we have tests! 👍
jeremyfiel
force-pushed
the
schema-test
branch
from
979384c
to
3111890
Compare
jeremyfiel
force-pushed
the
schema-test
branch
2 times, most recently
from
d1907bc
to
84db575
Compare
|
@jeremyfiel Could you please add a That's the only part of the schema that is not yet tested. |
jeremyfiel
force-pushed
the
schema-test
branch
2 times, most recently
from
dc198e7
to
5517ebc
Compare
|
should be all covered now |
Sorry, should have been more precise: please add to a "pass" test case, the "fail" ones don't count into the schema coverage. |
* fixup `target` json path
jeremyfiel
force-pushed
the
schema-test
branch
from
5517ebc
to
4b9a9d2
Compare
includes pass and fail scenarios for Overlay schema tests.
Also includes the full schema per #72