Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Request Body Object #162

Merged
merged 3 commits into from
Mar 28, 2024
Merged

feat: Add Request Body Object #162

merged 3 commits into from
Mar 28, 2024

Conversation

frankkilcommins
Copy link
Collaborator

@frankkilcommins frankkilcommins commented Mar 13, 2024

fixes #152

Hoping to omit encoding for now and delegate that to the referenced OpenAPI descriptions

@frankkilcommins frankkilcommins marked this pull request as ready for review March 13, 2024 22:59
This was referenced Mar 13, 2024
@frankkilcommins frankkilcommins added the implementor-draft In scope for first version label Mar 13, 2024
Copy link
Collaborator

@kevinduffey kevinduffey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments.. waiting on those to approve

examples/1.0.0/oauth.workflow.yaml Show resolved Hide resolved
examples/1.0.0/pet-coupons.workflow.yaml Show resolved Hide resolved
Copy link
Collaborator

@kevinduffey kevinduffey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankkilcommins frankkilcommins merged commit c8ac12e into OAI:main Mar 28, 2024
1 check passed
frankkilcommins added a commit that referenced this pull request Mar 28, 2024
…170)

* chore: suggest multilevel parameters (#155)

* chore: suggest multilevel parameters

* Update versions/1.0.0.md

Co-authored-by: Frank Kilcommins <[email protected]>

* Update examples/1.0.0/ExtendedParametersExample.workflow.yaml

Co-authored-by: Frank Kilcommins <[email protected]>

* Update versions/1.0.0.md

Co-authored-by: Frank Kilcommins <[email protected]>

---------

Co-authored-by: Frank Kilcommins <[email protected]>

* Remove references to WHATWG to avoid confusion (#145)

* Remove references to WHATWG to avoid confusion

* Correct relative reference wording

* Section 4.2 not 4.1!

* Simplify URI wording

* Adjust Step Parameters desc to cater for Workflow parameters addition (#169)

* feat: add `dependsOn` capability for workflow level (#164)

* feat: add `dependsOn` capability for workflow level

* chore: typo fix

* chore: grammer fix

* feat: Add Request Body Object (#162)

* feat: Add Request Body Object

* chore: fix typos in examples

* Clarity on referencing Components Parameters (#149)

* Clarity on referencing Components Parameters

* Remove Reference Object to avoid clash with JSON Schema keyword. Replace with expression based referencing

* chore: keep fixed field link names consistent

* chore: Name component parameters as type Reusable Parameter Object

* chore: adjust Workflow level parameters to use Reusable Parameter Objects

---------

Co-authored-by: Dmytro Anansky <[email protected]>
Co-authored-by: Nick Denny <[email protected]>
frankkilcommins added a commit that referenced this pull request Apr 3, 2024
* feat: adding support for share success and failure actions

* Merging latest 'main' changes in to Action Object Extensions branch (#170)

* chore: suggest multilevel parameters (#155)

* chore: suggest multilevel parameters

* Update versions/1.0.0.md

Co-authored-by: Frank Kilcommins <[email protected]>

* Update examples/1.0.0/ExtendedParametersExample.workflow.yaml

Co-authored-by: Frank Kilcommins <[email protected]>

* Update versions/1.0.0.md

Co-authored-by: Frank Kilcommins <[email protected]>

---------

Co-authored-by: Frank Kilcommins <[email protected]>

* Remove references to WHATWG to avoid confusion (#145)

* Remove references to WHATWG to avoid confusion

* Correct relative reference wording

* Section 4.2 not 4.1!

* Simplify URI wording

* Adjust Step Parameters desc to cater for Workflow parameters addition (#169)

* feat: add `dependsOn` capability for workflow level (#164)

* feat: add `dependsOn` capability for workflow level

* chore: typo fix

* chore: grammer fix

* feat: Add Request Body Object (#162)

* feat: Add Request Body Object

* chore: fix typos in examples

* Clarity on referencing Components Parameters (#149)

* Clarity on referencing Components Parameters

* Remove Reference Object to avoid clash with JSON Schema keyword. Replace with expression based referencing

* chore: keep fixed field link names consistent

* chore: Name component parameters as type Reusable Parameter Object

* chore: adjust Workflow level parameters to use Reusable Parameter Objects

---------

Co-authored-by: Dmytro Anansky <[email protected]>
Co-authored-by: Nick Denny <[email protected]>

* Add Reusable Object and referencing ability

* chore: fix yaml example indentation

* chore: fix JSON examples

* chore: fix typo in `workflowStepActions`

---------

Co-authored-by: Dmytro Anansky <[email protected]>
Co-authored-by: Nick Denny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementor-draft In scope for first version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request body design update?
2 participants