Non-substantive changes to conform to recommendations #43
Conversation
Add repository info
Add keywords
michmich > magicmirror
new Date() >new Date(Date.now())
Add keyword
|
Added astronomy (which has the added benefit of fixing the trailing comma) |
spell Astronomy right
images/example1.png
Outdated
There was a problem hiding this comment.
I don't see this file being used anywhere - Is it different from 2023-09-15-example-moons.png?
There was a problem hiding this comment.
I think I duplicated one of the images and gave it a filename that would make it show up as the thumbnail here https://kristjanesperanto.github.io/MagicMirror-3rd-Party-Modules/. Probably not "used" anywhere.
There was a problem hiding this comment.
With this PR in its current state, the image for this module will not change in the new module list. The first image containing the word "example" would be used there, and that would still be 2019-06-22-example-moons.png.
I think it would be best to remove all unused images and leave only the used one. This will be used in the list 🙂
There was a problem hiding this comment.
Ahh...containing the word "example". I thought it had to start with that word. Will make the change.
There was a problem hiding this comment.
Done. Though I just renamed the old image in case you ever have a need for it again.
There was a problem hiding this comment.
Very good, with that you could remove example1.png 🙂
There was a problem hiding this comment.
I did that, but forgot to commit. Committed now.
Grunt is actually unused and references to it within If you wanted to do that in this PR I'd appreciate it. |
Remove grunt
Done. |
changed file name to allow current image to appear in https://kristjanesperanto.github.io/MagicMirror-3rd-Party-Modules/
Non-substantive changes as recommended here https://github.com/KristjanESPERANTO/MagicMirror-3rd-Party-Modules/blob/main/result.md#MMM-MoonPhase-by-NolanKingdon
They also recommend:
gruntreferences in package.json with "something better"Changing the primary branch name tomainUpdate: I don't recommend changing the branch name as it will mess with
git pull