Feature/add cmake support #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents a hang and/or segfault when trying to lock a moved-from observer. When moving an observer, we now do the equivalent of a disconnect_all on the source object, and also re-wire those connections onto the target object: - Insert all connections previously on the source object into the target - On all connected observers, disconnect them from the source object and re-connect to the target
…, disconnect_all is a noop and we don't need movedFrom
…onstructors Explicitly default/delete copy and move constructors for signal and observer types
Enhanced the move tests and resolved uncovered issues in move_connections_from. Normalized method names, default statement locations, comments.
use CPM for booststap use catch2 for unit tests, not yet finisched!
add used but missing includes (include_what_you_use)
mv header to include subdir
…o-signal-slot into feature/add-cmake-support
|
Thank you for this PR as well as that opened issue (that is still to be reviewed...). The only thing I can say is to possibly add some text in tests/readme concerning the need for catch2 and a link to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be portable, I had to use
catch2instead ofCppUnitTestFramework