PHP8.4 deprecation notices fix attempt

[NielBuys]

Attempt to Fix below issues
bcit-ci#6302
bcit-ci#6300
bcit-ci#6300

[NielBuys]

Changes not tested on php8.4 yet. But it should remove notices. Changes works on my php8.3 environment.

[jamieburchell]

Should probably bump the required PHP version to 7.1 if using nullable types. I personally don't care about anything < PHP 8.2, but I'm not sure if these PRs are supposed to be compatible with the PHP version mentioned in composer.json.

[jamieburchell]

Won't there still be deprecation notices in PHP 8.4 because session.sid_length is still being used?

[NielBuys]

Should probably bump the required PHP version to 7.1 if using nullable types. I personally don't care about anything < PHP 8.2, but I'm not sure if these PRs are supposed to be compatible with the PHP version mentioned in composer.json.

On my fork I have bumped the minimum php version to 7.4. That's the reason I have not pushed this pull request to the main repository.

[NielBuys]

Won't there still be deprecation notices in PHP 8.4 because session.sid_length is still being used?

Thanks for the heads up. I haven't tested my changes with PHP 8.4 yet; I've only researched and made the updates. I'll look into session.sid_length and set up a test environment for PHP 8.4.

[NielBuys]

Won't there still be deprecation notices in PHP 8.4 because session.sid_length is still being used?

The session.sid_length section of the code was sourced from the pull request (codeigniter4/CodeIgniter4#9139) for CodeIgniter 4, which was referenced in issue bcit-ci#6300.

[jamieburchell]

The session.sid_length section of the code was sourced from the pull request (codeigniter4/CodeIgniter4#9139) for CodeIgniter 4, which was referenced in issue bcit-ci#6300.

Yup, that forces the params for <PHP9, but it will still trigger a deprecation error. CI4 gets around that in a different way

[jamieburchell]

At this point and assuming it stops the deprecation notice, I think I'd be tempted to simply prefix the ini_set call for session.sid_length and session.sid_bits_per_character with the error suppression character '@'.

[NielBuys]

At this point and assuming it stops the deprecation notice, I think I'd be tempted to simply prefix the ini_set call for session.sid_length and session.sid_bits_per_character with the error suppression character '@'.

After reviewing it, I believe you're right; it will still trigger the deprecation notice. I think it’s a good idea to add the @ symbol in front of ini_set. I will make that change and then test to see if it works.

[jamieburchell]

@NielBuys I was feeling brave and decided to go all-out in my branch and remove code supporting < PHP 7.4. It might benefit you and your repo. Comments welcome too!

[NielBuys]

@NielBuys I was feeling brave and decided to go all-out in my branch and remove code supporting < PHP 7.4. It might benefit you and your repo. Comments welcome too!

Thanks, I agree that it's a good idea to clean up some of the older PHP version code. I've created a patch file from your commit and will review it. I’ll let you know if I encounter any issues.