Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate EventWaveform class #1940

Merged
merged 7 commits into from
Nov 19, 2024
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Jul 23, 2024

Motivation

Corresponds to NeurodataWithoutBorders/nwb-schema#584

  • Waiting on test suite to pass
  • Waiting on schema changes to merge to dev

How to test the behavior?

EventWaveform()  # should return a ValueError

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (nwb_schema_2.8.0@f89ce99). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/pynwb/ecephys.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             nwb_schema_2.8.0    #1940   +/-   ##
===================================================
  Coverage                    ?   92.02%           
===================================================
  Files                       ?       27           
  Lines                       ?     2709           
  Branches                    ?      706           
===================================================
  Hits                        ?     2493           
  Misses                      ?      141           
  Partials                    ?       75           
Flag Coverage Δ
integration 72.90% <33.33%> (?)
unit 82.98% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rly rly changed the base branch from dev to nwb_schema_2.8.0 September 20, 2024 05:16
@rly
Copy link
Contributor Author

rly commented Nov 19, 2024

I accidentally updated the changelog in the nwb_schema_2.8.0 branch. I think we can move forward with this commit to that branch.

@rly rly requested a review from stephprince November 19, 2024 17:14
@rly rly marked this pull request as ready for review November 19, 2024 17:50
@rly rly merged commit 2c44de4 into nwb_schema_2.8.0 Nov 19, 2024
23 of 24 checks passed
@rly rly deleted the deprecate_event_waveform branch November 19, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants