Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataset to store list of software that produced a file #1924

Merged
merged 9 commits into from
Nov 19, 2024

Conversation

stephprince
Copy link
Contributor

@stephprince stephprince commented Jun 27, 2024

Motivation

Related pynwb changes for the proposed nwb-schema PR for provenance information.

TODO

  • Update to merge into nwb_schema_2.8.0 branch when reviewed

How to test the behavior?

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.30%. Comparing base (dc98e84) to head (0b3be53).

❗ There is a different number of reports uploaded between BASE (dc98e84) and HEAD (0b3be53). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (dc98e84) HEAD (0b3be53)
integration 4 0
Additional details and impacted files
@@                 Coverage Diff                  @@
##           nwb_schema_2.8.0    #1924      +/-   ##
====================================================
- Coverage             91.85%   83.30%   -8.56%     
====================================================
  Files                    27       27              
  Lines                  2689     2689              
  Branches                701      701              
====================================================
- Hits                   2470     2240     -230     
- Misses                  145      352     +207     
- Partials                 74       97      +23     
Flag Coverage Δ
integration ?
unit 83.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephprince stephprince changed the base branch from dev to nwb_schema_2.8.0 September 19, 2024 17:00
@stephprince stephprince changed the base branch from nwb_schema_2.8.0 to dev September 19, 2024 17:01
@stephprince stephprince marked this pull request as ready for review September 19, 2024 17:02
@stephprince
Copy link
Contributor Author

@rly with the support for writing multidimensional string arrays merged into hdmf, this should be ready to be reviewed.

I think all of the failing tests are from the other 2.8.0 schema changes (SpatialSeries.bounds and ragged Units.waveform_mean/sd)

@rly rly changed the base branch from dev to nwb_schema_2.8.0 September 20, 2024 21:02
@rly rly merged commit 1b46014 into nwb_schema_2.8.0 Nov 19, 2024
4 of 21 checks passed
@rly rly deleted the provenance-tracking branch November 19, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants