Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protein coverage calculation #1810

Open
apsteinberg opened this issue Oct 2, 2024 · 5 comments
Open

Protein coverage calculation #1810

apsteinberg opened this issue Oct 2, 2024 · 5 comments
Assignees

Comments

@apsteinberg
Copy link

Hi all,

I had a quick question regarding how the calculation of protein coverage is performed in the protein.tsv report. I was trying to compute protein coverage by using the results that are in the peptide.tsv -- basically, I was taking the Protein Start and Protein End positions listed for each peptide related to a given protein in the peptide.tsv file, and using these to compute protein coverage. I am finding there is a slight discrepancy between the values. Does the protein coverage listed in the protein.tsv report include some additional peptides?

Thanks,
Asher

@fcyu fcyu self-assigned this Oct 2, 2024
@fcyu
Copy link
Member

fcyu commented Oct 2, 2024

Hi Asher,

It is calculated by ProteinProphet. If I remember it correctly, it uses all peptides from all samples/input files.

Best,

Fengchao

@anesvi
Copy link
Collaborator

anesvi commented Oct 2, 2024

I though we were even going to remove that column, Fengchao? Yes I think it is from ProteinProphet which uses peptides with a weight of 0.5 and above. But philosopher is using a modified razor assignment logic so the set of peptides assigned as razor peptides to each protein is different. But I have to check to see what we are really printing in that column.

@apsteinberg
Copy link
Author

Hi Fengchao and Alexey,

Thanks for the quick response. If I am understanding correctly, the peptides in the peptide.tsv are slightly different than those used for the protein coverage calculation that is included in the protein.tsv output?

Best,
Asher

@fcyu
Copy link
Member

fcyu commented Oct 3, 2024

That's correct. The protein coverage calculation was not well implemented in Philosopher. We need to change that.

Best,

Fengchao

@apsteinberg
Copy link
Author

Got it. Thank you both, this is super helpful!

Best,
Asher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants