Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 调整 Dart Sass 的 warnings 配置 #16604

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

koppthe
Copy link
Contributor

@koppthe koppthe commented Sep 26, 2024

这个 PR 做了什么? (简要描述所做更改)

关闭 Dart Sass 的 legacy-js-api 的 warnings
https://github.com/sass/dart-sass/blob/main/CHANGELOG.md#js-api
image

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.51%. Comparing base (9174d18) to head (0d36a44).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main   #16604    +/-   ##
========================================
  Coverage   58.51%   58.51%            
========================================
  Files         466      466            
  Lines       27109    27109            
  Branches     5948     5719   -229     
========================================
  Hits        15862    15862            
+ Misses       9868     9791    -77     
- Partials     1379     1456    +77     
Flag Coverage Δ
taro-cli 73.67% <ø> (ø)
taro-runtime 59.83% <ø> (ø)
taro-web 52.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 38 files with indirect coverage changes

@koppthe koppthe added this to the 4.0.7 milestone Sep 26, 2024
@ZEJIA-LIU ZEJIA-LIU merged commit bcbd228 into main Sep 26, 2024
38 checks passed
@ZEJIA-LIU ZEJIA-LIU deleted the feat/sass-options branch September 26, 2024 12:11
This was referenced Sep 28, 2024
@IamFive
Copy link

IamFive commented Sep 30, 2024

  • 4.07撒时候可以release啊,这个问题会 block 这个工程。
  • 这个问题在 4.0.6 下,有修复方法吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants