feat(float-layout): 增加参数top,类型为Booolean,默认值为false,控制浮动弹层是否顶部弹出 #738 #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnOrdinaryMan
changed the title
|
这块单独抽离一个 Popup 组件是不是更合适一些呢？ |
这里仅仅是改变了弹出的位置，需要因此单独抽离为一个组件吗 |
|
抽离一个 Popup 组件更合理一些，FloatLayout 的交互规范不能更改哈 |
|
请问该功能是否已实现 |
如上，官方建议抽离成一个Popup组件，未采纳PR |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#738