Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remember entry._type #258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remember entry._type #258

wants to merge 1 commit into from
+1 −0

Conversation

dehann
Copy link
Member

@dehann dehann commented Oct 7, 2024

Required for better duck-type usage

@dehann dehann requested a review from Affie October 7, 2024 15:52
@Affie
Copy link
Member

Affie commented Oct 7, 2024

_type is deprecated in the BlobEntry type. It's a leftover of when we had an AbstractBlobEntry

Base automatically changed from dev/v5 to main October 15, 2024 19:43
@dehann
Copy link
Member Author

dehann commented Oct 22, 2024

@Affie please keep _type in, do not deprecate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Affie Affie Awaiting requested review from Affie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dehann @Affie