Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT proposal : convert species on the fly #57

Closed
wants to merge 6 commits into from

Conversation

alexbelgium
Copy link

@alexbelgium alexbelgium commented May 13, 2024

ISSUE : At least two common birds in my garden are systematically misidentified as another very rare specie, when they perform a call instead of a song. I don't want to exclude those birds however of they would never be recognized as it is a systematic model issue

PROPOSED SOLUTION : This PR proposes the use of an optional user created "convert_species_list.txt" in the format "old sci name_old common name;new sci name_new common name" to avoid this

COMMENT : I've modified code using the management of the exclude_species_list.txt as template to create and init the file. The only specific code written is its usage in the server.py

@alexbelgium alexbelgium changed the title WIP : convert species on the fly FEAT proposal : convert species on the fly May 13, 2024
@alexbelgium
Copy link
Author

Hi @Nachtzuster, what do you think ? I'm not really used to python but in theory it should allow to convert on the fly species to correct for model bias - I would love your input if there is a better way to do it :-)

Please let me know if you are not interested as it modifies the server.py and might be due to a very specific usage and I'll just implement it in my addon for my personal usage :-)

Thanks!

@alexbelgium alexbelgium marked this pull request as draft May 13, 2024 11:39
@alexbelgium alexbelgium marked this pull request as draft May 13, 2024 11:39
@alexbelgium
Copy link
Author

not working yet

@Nachtzuster
Copy link
Owner

Nachtzuster commented May 15, 2024

@alexbelgium I probably won't be merging this, seems to be fixing an issue in the wrong place

This is really an issue for 'upstream' (BirdNET-Pi is using this model)

@alexbelgium
Copy link
Author

alexbelgium commented May 15, 2024

@alexbelgium I probably won't be merging this, seems to be fixing an issue in the wrong place

This is really an issue for 'upstream' (BirdNET-Pi is using this model)

Fair enough! Indeed this solution shouldn't exist ;-) I just noticed that systematically I have 3 species that are confused with another (after checking manually the sounds recordings) and given that species are sent to birdweather as soon as they are identified, birdweather is filled with erroneous elements... But indeed it should be corrected at the model level and not at the app. Thanks !

@alexbelgium alexbelgium deleted the patch-4 branch May 16, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants